openstack/puppet-cinder
Code Issues Proposed changes

Fix cinder-qos provider issue with openstackclient >= 3.8.0

Browse Source 
output of culmn name change making failed cinder-qos provider
column name 'Specs' changed to 'Properties'

Change-Id: I9470ed3f60971394740b19a2f42e4b55b5d046ea
Closes-bug: 1806705
This commit is contained in:
Alexandre Arents 2018-12-04 15:41:38 +01:00 committed by zhongshengping
parent 8f4fc18833
commit 0fc0043a29
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/puppet/provider/cinder_qos/openstack.rb
View File

@ -64,11 +64,15 @@ Puppet::Type.type(:cinder_qos).provide(
def self.instances
list = request('volume qos', 'list')
list.collect do |qos|
properties = qos[:properties]
unless qos[:specs].nil?
properties = qos[:specs]
end
new({
:name => qos[:name],
:ensure => :present,
:id => qos[:id],
:properties => string2array(qos[:specs]),
:properties => string2array(properties),
:consumer => qos[:consumer],
:associations => string2array(qos[:associations])
})

17
spec/unit/provider/cinder_qos/openstack_spec.rb
View File

@ -79,6 +79,23 @@ properties="key1=\'value1\', key2=\'value2\'"
end
end
#Test with python-openstackclient => 3.8.0 output (column header change from 'Specs' to 'Properties')
describe '#instances' do
it 'finds qos' do
provider_class.expects(:openstack)
.with('volume qos', 'list', '--quiet', '--format', 'csv', [])
.returns('"ID","Name","Consumer","Associations","Properties"
"28b632e8-6694-4bba-bf68-67b19f619019","qos-1","front-end","my_type1","read_iops=\'value1\'"
')
instances = provider_class.instances
expect(instances.count).to eq(1)
expect(instances[0].name).to eq('qos-1')
expect(instances[0].associations).to eq(['my_type1'])
expect(instances[0].consumer).to eq('front-end')
expect(instances[0].properties).to eq(['read_iops=value1'])
end
end
describe '#string2array' do
it 'should return an array with key-value' do
s = "key='value', key2='value2'"