lint: Fix lint issues (missing documentation for define types)

The gem 'puppet-lint-param-docs' was bumped to 1.2.0 and now handle
class and define type. This patch fix lint issues (missing documentation).

Change-Id: I25515b524b9dcce9356b18c422c4db5352a528f2

manifests/backend/emc_vnx.pp

@@ -10,6 +10,9 @@
 #   (optional) Allows for the volume_backend_name to be separate of $name.
 #   Defaults to: $name
 #
+# [*iscsi_ip_address*]
+#   (Required) The IP address that the iSCSI daemon is listening on
+#
 # [*san_ip*]
 #   (required) IP address of SAN controller.
 #

manifests/backend/hp3par_iscsi.pp

@@ -36,6 +36,9 @@
 #   (optional) Setup cinder-volume to use HP 3par volume driver.
 #   Defaults to 'cinder.volume.drivers.san.hp.hp_3par_iscsi.HP3PARISCSIDriver'
 #
+# [*hp3par_iscsi_chap_enabled*]
+#   (required) setting to false by default
+#
 # [*hp3par_iscsi_chap_enabled
 #   (required) setting to false by default
 #

manifests/backend/iscsi.pp

@@ -1,6 +1,10 @@
 #
 # Define: cinder::backend::iscsi
-# Parameters:
+#
+# === Parameters:
+#
+# [*iscsi_ip_address*]
+#   (Required) The IP address that the iSCSI daemon is listening on
 #
 # [*volume_backend_name*]
 #   (optional) Allows for the volume_backend_name to be separate of $name.
@@ -10,10 +14,22 @@
 #   (Optional) Driver to use for volume creation
 #   Defaults to 'cinder.volume.drivers.lvm.LVMVolumeDriver'.
 #
+# [*volume_group*]
+#   (Optional) Name for the VG that will contain exported volumes
+#   Defaults to 'cinder-volumes'.
+#
 # [*volumes_dir*]
 #   (Optional) Volume configuration file storage directory
 #   Defaults to '/var/lib/cinder/volumes'.
 #
+# [*iscsi_helper*]
+#   (Optional) iSCSI target user-land tool to use.
+#   Defaults to '$::cinder::params::iscsi_helper'.
+#
+# [*iscsi_protocol*]
+#   (Optional) Protocol to use as iSCSI driver
+#   Defaults to 'iscsi'.
+#
 # [*extra_options*]
 #   (optional) Hash of extra options to pass to the backend stanza
 #   Defaults to: {}

manifests/backend/netapp.pp

@@ -5,6 +5,10 @@
 #
 # === Parameters
 #
+# [*volume_backend_name*]
+#   (optional) The name of the cinder::backend::netapp ressource
+#   Defaults to $name.
+#
 # [*netapp_login*]
 #   (required) Administrative user account name used to access the storage
 #   system or proxy server.

manifests/backend/san.pp

@@ -46,6 +46,10 @@
 # [*ssh_min_pool_conn*]
 #   (optional) Maximum ssh connections in the pool.
 #
+# [*ssh_max_pool_conn*]
+#   (Optional) Maximum ssh connections in the pool.
+#   Defaults to '5'.
+#
 # [*extra_options*]
 #   (optional) Hash of extra options to pass to the backend stanza
 #   Defaults to: {}

manifests/backend/vmdk.pp

@@ -22,7 +22,7 @@
 #   e.g., socket error, etc.
 #   Defaults to 10.
 #
-# [*$max_object_retrieval*]
+# [*max_object_retrieval*]
 #   (optional) The maximum number of ObjectContent data objects that should
 #   be returned in a single result. A positive value will cause
 #   the operation to suspend the retrieval when the count of