openstack
/
puppet-glance
Code Issues Proposed changes

Expose executor_thread_pool_size 

This option has been supported by puppet-oslo but has not been
configurable.

Change-Id: Ifb38f1275721387ba5166feb351c27e4c3ae2999
This commit is contained in:
Takashi Kajinami 2023-03-06 13:54:04 +09:00
parent 43735fb127
commit 293c3d20de
3 changed files with 23 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
manifests/notify/rabbitmq.pp
View File

@ -17,6 +17,10 @@
# option.
# Defaults to $facts['os_service_default']
#
# [*executor_thread_pool_size*]
# (Optional) Size of executor thread pool when executor is threading or eventlet.
# Defaults to $facts['os_service_default'].
#
# [*notification_transport_url*]
# (optional) Connection url for oslo messaging notification backend. An
# example rabbit url would be, rabbit://user:pass@host:port/virtual_host
@ -107,6 +111,7 @@ class glance::notify::rabbitmq(
$default_transport_url = $facts['os_service_default'],
$rpc_response_timeout = $facts['os_service_default'],
$control_exchange = $facts['os_service_default'],
$executor_thread_pool_size = $facts['os_service_default'],
$notification_transport_url = $facts['os_service_default'],
$rabbit_ha_queues = $facts['os_service_default'],
$rabbit_heartbeat_timeout_threshold = $facts['os_service_default'],
@ -144,9 +149,10 @@ class glance::notify::rabbitmq(
}
oslo::messaging::default { 'glance_api_config':
transport_url => $default_transport_url,
rpc_response_timeout => $rpc_response_timeout,
control_exchange => $control_exchange,
executor_thread_pool_size => $executor_thread_pool_size,
transport_url => $default_transport_url,
rpc_response_timeout => $rpc_response_timeout,
control_exchange => $control_exchange,
}
oslo::messaging::notifications { 'glance_api_config':

5
releasenotes/notes/executor_thread_pool_size-5f3f56a67dbbde78.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
The new ``glance::notify::rabbitmq::executor_thread_pool_size`` parameter
has been added.

15
spec/classes/glance_notify_rabbitmq_spec.rb
View File

@ -20,9 +20,10 @@ describe 'glance::notify::rabbitmq' do
) }
it { is_expected.to contain_oslo__messaging__default('glance_api_config').with(
:transport_url => '<SERVICE DEFAULT>',
:rpc_response_timeout => '<SERVICE DEFAULT>',
:control_exchange => '<SERVICE DEFAULT>',
:executor_thread_pool_size => '<SERVICE DEFAULT>',
:transport_url => '<SERVICE DEFAULT>',
:rpc_response_timeout => '<SERVICE DEFAULT>',
:control_exchange => '<SERVICE DEFAULT>',
) }
it { is_expected.to contain_oslo__messaging__notifications('glance_api_config').with(
@ -38,6 +39,7 @@ describe 'glance::notify::rabbitmq' do
:default_transport_url => 'rabbit://user:pass@host:1234/virt',
:rpc_response_timeout => '120',
:control_exchange => 'glance',
:executor_thread_pool_size => 64,
:notification_transport_url => 'rabbit://user:pass@alt_host:1234/virt',
:rabbit_ha_queues => true,
:rabbit_heartbeat_timeout_threshold => '60',
@ -74,9 +76,10 @@ describe 'glance::notify::rabbitmq' do
) }
it { is_expected.to contain_oslo__messaging__default('glance_api_config').with(
:transport_url => 'rabbit://user:pass@host:1234/virt',
:rpc_response_timeout => '120',
:control_exchange => 'glance',
:executor_thread_pool_size => 64,
:transport_url => 'rabbit://user:pass@host:1234/virt',
:rpc_response_timeout => '120',
:control_exchange => 'glance',
) }
it { is_expected.to contain_oslo__messaging__notifications('glance_api_config').with(