openstack
/
puppet-glance
Code Issues Proposed changes

acceptance: drop dependency cycles tests 

They bring no value in our CI, we already test a full deployment of
Glance and workflow of image upload, we don't need them.
Moreover, they make our life complicated when debbuging CI issues.

Let's drop the tests.

Change-Id: I94fa88d661dc83d4f1803ab3275ff0cfa58b6c5b
This commit is contained in:
Emilien Macchi 2016-04-08 15:24:42 -04:00
parent 5d6e42356e
commit 31c15aefd4
1 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
spec/acceptance/basic_glance_spec.rb
View File

@ -53,26 +53,6 @@ describe 'glance class' do
}
EOS
it 'should configure the glance endpoint before the glance-api service uses it' do
pp2 = pp + "Service['glance-api'] -> Keystone_endpoint['RegionOne/Image Service::image']"
expect(apply_manifest(pp2, :expect_failures => true, :noop => true).stderr).to match(/Found 1 dependency cycle/i)
end
it 'should configure the glance user before the glance-api service uses it' do
pp2 = pp + "Service['glance-api'] -> Keystone_user_role['glance@services']"
expect(apply_manifest(pp2, :expect_failures => true, :noop => true).stderr).to match(/Found 1 dependency cycle/i)
end
it 'should configure the glance user before the glance-registry service uses it' do
pp2 = pp + "Service['glance-registry'] -> Keystone_user_role['glance@services']"
expect(apply_manifest(pp2, :expect_failures => true, :noop => true).stderr).to match(/Found 1 dependency cycle/i)
end
it 'should configure the glance-api service before using it to provision glance_images' do
pp2 = pp + "Glance_image['test_image'] -> Service['glance-api']"
expect(apply_manifest(pp2, :expect_failures => true, :noop => true).stderr).to match(/Found 1 dependency cycle/i)
end
it 'should work with no errors' do
# Run it twice and test for idempotency
apply_manifest(pp, :catch_failures => true)