openstack/puppet-glance
Code Issues Proposed changes

glance::client was not installing the correct package

Browse Source 
The actually glance executable is not installed as a part
of the python-glance package, it is installed in the
python-glanceclient pakcage.

Going through the RDO packages, I do not even see a package
called python-glance.

Change-Id: I35c71fc5da595a695b10cb2ecc5ad27f5131bac8
This commit is contained in:
Dan Bode 2013-06-20 10:20:22 -07:00
parent ebb78d8d01
commit 53d2b7eeb6
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/client.pp
View File

@ -10,7 +10,7 @@ class glance::client (
include glance::params include glance::params
package { 'python-glance': package { 'python-glanceclient':
name => $::glance::params::client_package_name, name => $::glance::params::client_package_name,
ensure => $ensure, ensure => $ensure,
} }

2
manifests/params.pp
View File

@ -2,7 +2,7 @@
# should be considered to be constant # should be considered to be constant
class glance::params { class glance::params {
$client_package_name = 'python-glance' $client_package_name = 'python-glanceclient'
case $::osfamily { case $::osfamily {
'RedHat': { 'RedHat': {

4
spec/classes/glance_client_spec.rb
View File

@ -4,8 +4,8 @@ describe 'glance::client' do
shared_examples 'glance client' do shared_examples 'glance client' do
it { should include_class('glance::params') } it { should include_class('glance::params') }
it { should contain_package('python-glance').with( it { should contain_package('python-glanceclient').with(
:name => 'python-glance', :name => 'python-glanceclient',
:ensure => 'present' :ensure => 'present'
) )
} }