Commit 031609b57284cf13877ce727c2e4672831a3dbe2 changed the way
is_public was munged. However, when testing it it looks like it
was always seen as an empty string after this, so all created
images were private. Changing the way the 'if' block is done fixes
it.
Change-Id: If2eb52a6d0d9be89c9323702616f62f8ecba5e02
glance expects True/False values whereas this type uses Yes/No.
Without this patch, puppet would return the following message with an
existing glance image with is_public attribute already set to 'True'.
puppet-agent[18190]: (/Stage[main]/Site::Controller/Glance_image[raring-server-cloudimg-amd64]/is_public) is_public changed 'True' to 'Yes'
Change-Id: I532e08e6815a8b03f5eb6a9495d886b9855762c8
When trying to upload an image from the local file system, the
resource provider was failing. Fixing it to use the --file option
for the glance client instead of going through stdin.
Change-Id: Ic6bade025d28e2eb33f86c2d4421b65d06e8274c
This is pretty important in situations where Keystone contains information about
multiple regions. The holding assumption is that the glance::image etc are used
for image upload for the current region.
Change-Id: I0a24cd24ddf3e0b1fab94e693a2fac847cc7271c
Since this patch has been merged in python-glanceclient 0.14.1:
1dfce5301c
We have to update the way to call Glance Client.
This patch updates for glance image-list, image-show and the way to get
a token, and also the way the glance command output is parsed.
Change-Id: If3e1e42b1245dd064fa00e07037535afc9caa04c
Currently secrets like rabbit_password or admin_password are displayed in
puppet logs when changed. This commit changes glance_*_config and
glance_*_ini types adding a new parameter that triggers obfuscation of
the values in puppet logs.
Change-Id: I31f974a9afadef42939ee092ecba3b8f4333bb8b
Closes-Bug: #1328448
The output of the glance show command in get_glance_image_attrs
does not get properly converted while being added to the
attrs array.
Change-Id: Ibe503b24ae3bfa10944537d5deaa068a01eaa5f3
Closes-Bug: #1199513
The python-glanceclient (glance) was updated to not report back
on the id of an uploaded image with the v2 API [1]. This broke
the parser for the glance_image provider. This change first checks
for the previous behavior (for performance and backwards
compatability), and failing that parses the results table and
pulls the id (if it exits) out of the results.
The new parse_table method was made to be generic so that any result
from the glance client could be parsed into an array of maps.
[1]
https://github.com/openstack/python-glanceclient/search?q=Added+new+image+with+ID&ref=cmdform
Change-Id: If7b5445c6f51d886427248827a73cc16b5a2e488
Some arguments are deprecated in API v2.
This patch aims to update glance_image provider to fit with the
OpenStack Images API v2.0 (latest stable).
Note: Glance API v2 is by default from OpenStack Folsom release.
Change-Id: Ic06a839324aa0a6e11b16a13ad8927a1da6e13e4
Signed-off-by: Emilien Macchi <emilien.macchi@enovance.com>
Glance client is getting the same warnings as Keystone client,
hence puppet-glance should use the same hack as puppet-keystone
until providers will be refactored to use API calls instead.
See https://bugzilla.redhat.com/show_bug.cgi?id=1043725 for more details
Change-Id: I99e4308d0731307c019ad6cab8db5feee1b0ed73
Python-glanceclient removed the --silent-upload some time ago (I
believe when the client was split out from Glance itself). It's no
longer valid and needs to be removed. Otherwise users will see
an error of the form:
glance: error: unrecognized arguments: --silent-upload
Change-Id: I417688872bd8e7c4bac7be13d0b0eb13a030fe29
Just b/c the glance service has started correctly does not
mean the service is actually running. Often, the service
is not operational and attempts to use the glance_image provider
results in connection errors.
This commit inserts code that allows the glance provider to
sleep for 10 seconds and perform a single retry.
The template for the code and tests was borrowed from keystone.
Change-Id: I565f1befea6ec3d2347f8e29c9aa05d5a312a827
Check if auth_admin_prefix is defined (passed as a parameter to api.pp)
before trying to access it in the settings data structure.
Change-Id: I61a3ae41dca2a5e5bd9e635b0a2ab9eb05b0326a
Fixes: bug #1190481
This patch allows the usage of Puppet boolean values and still
configure values with OpenStack boolean style: True/False.
Change-Id: I1f96bf979e67fd7fb8fd1d984809fd072783224c
In order for the ini file type to support purging,
the file path must be accessible on the class instance.
This patch was made to test some new functionality being added
to the inifile type
https://github.com/cprice-puppet/puppetlabs-inifile/pull/25
It does effect backwards compat of this native type so its ok
to go ahead and merge.
This commit introduces a refactor of glance_image.
ensure that it follows the best practices for provider development.
- use property hash
- use mk_resource_methods
- update property hash on create and delete.
ensure that it keeps it property hash reasobly up to date.
- Add native types to manage all existing ini files
- remove all unused templates
- convert all concat with ini_setting resources
- remove all concat code
