438 Commits

Author SHA1 Message Date
Colleen Murphy
c71644d9eb Correct password parameter for glance::api
The testing keystone password was set to 'a_big_secret' throughout the
test manifest except for in the glance-api class, so the
glance-api.conf would have the wrong password and tests for
glance_image would fail. This patch sets the password to be consistent
across the manifest.

Change-Id: I8b781d3080b2dd5e894c84a23c892e4f153d8aa6
2015-06-08 13:40:50 -07:00
Colleen Murphy
59310353b0 Rename class_spec.rb to basic_glance_spec.rb
Move the main beaker-rspec basic test to be in line with conventions
from the other modules.

Change-Id: I2a4c26fa2aab7e5d2dd719ef2dfd04574b84159e
2015-06-08 13:40:49 -07:00
Emilien Macchi
104829144f Bring Redhat support to acceptance tests
OpenStack Infra has jobs to run this on both Ubuntu Trusty and CentOS7.

* Add minitest to Gemfile (dependency to run beaker on centos - see 11
  http://projects.theforeman.org/issues/2650 for details)
* separate nodepool files to have trusty & centos7 support in OS infra
* class_spec: add case for repo configuration and support
  RH systems.
* don't install rabbitmq module that is not used (yet)
* install the apt module explicitly since it's no longer installed
  implicitly by the rabbitmq module

Change-Id: I17a571c8d56d55337ee0c8491fb4aad272074cf6
Closes-bug: #1444736
2015-06-08 13:40:33 -07:00
Emilien Macchi
d4563e25e7 Beaker: install APT repo with openstack_extras
Use openstack_extras module to manage Ubuntu Cloud Archive repository.

Change-Id: I163610d2f0207ffd836147498a67c604aa2b8dc7
2015-06-08 13:14:16 -07:00
Jenkins
199d90ec6c Merge "Add more details on running tests to the readme" 2015-06-07 14:39:14 +00:00
Jenkins
e39a6bf022 Merge "Fix ubuntu vagrant box nodesets" 2015-06-07 14:38:31 +00:00
Stanislaw Bogatkin
611045f213 Add endpoint type parameter
To point glance swift endpoint type, one optional parameter
was added.

Change-Id: I25ce5d9d119804f1aca5b5567be46750050ebacd
Closes-Bug: #1458811
2015-05-26 10:14:42 +00:00
Colleen Murphy
b8383e497e Add more details on running tests to the readme
Change-Id: I40f35e1a206e8a1b4ed880a1da978c4eba7e95e7
2015-05-11 13:53:00 -07:00
Colleen Murphy
ffc5c0c00b Fix ubuntu vagrant box nodesets
Without this patch, the nodesets incorrectly define a vagrantcloud vm
to install, resulting in the following error:

 > The box you're adding has a name different from the name you
 > requested.

This patch uses the trusty vagrant nodeset from the puppetlabs-apache
module and updates the default nodeset as well. Fill do the same for
the centos nodeset in a separate patch after RedHat tests are
implemented.

Change-Id: Iffac76b48d496d93b9cb63323ac103619319de47
2015-05-11 13:52:25 -07:00
Giulio Fidente
c76d39605f Decouple sync_db from manage_service and enabled
We want db_sync to run even though manage_service or enabled
can be set to False.

Change-Id: Ic3472ce6a6e704a2fa035df6e1c8866b8ea6bcbc
Closes-Bug: 1452278
2015-05-11 14:57:30 +02:00
Jenkins
0db42a6a60 Merge "Fix spec tests for RSpec 3.x and Puppet 4.x" 2015-04-28 19:44:01 +00:00
Dan Bode
1d38834466 make service description configurable
The previous commit that changed the service description
from Openstack to OpenStack actually introduced a bug that means
that users cannot upgrade between those two versions of the code.

An attempt to use this manifest to upgrade from earlier versions
of the code before this change was made is currently not supported
because keystone_service does not support updating it's description.

This commit adds the service description as a class parameter so that
folks using older version of the module can update it to the incorrectly
spelled version.

Change-Id: Id8b01c7456b067c19fcf6cc1503c22a11b7d3fd9
2015-04-28 09:31:17 -07:00
Sebastien Badia
60de7b77df Fix spec tests for RSpec 3.x and Puppet 4.x
Rix resource array, according[1].
[1]https://github.com/puppetlabs/puppet/blob/3.7.5/lib/puppet/resource.rb#L446-L453

Change-Id: Ic986a3cded93f6ab32c7bc27d8123c3f5e0befd1
Closes-bug: #1447620
2015-04-28 10:51:56 +02:00
Emilien Macchi
b76fbcbea3 glance provider: pick os_region_name from DEFAULT
In ::glance::api, os_region_name is set in DEFAULT which work for both
Juno & Kilo.

'glance_store' section has been introduced in Kilo which breaks Juno.
Until we decide our policy to manage master, let's use DEFAULT so both
releases work well.

Change-Id: I1c519146d3fe62f8c8fc8c2d85805db11af21e4c
2015-04-24 16:13:55 -04:00
Emilien Macchi
9f345f97d1 Bump rspec-puppet to 2.1.0
rspec-puppet 2.1.0 includes Puppet 4.0 support [1].

[1] https://github.com/rodjek/rspec-puppet/commits/v2.1.0

Change-Id: Ie3a5bc3045f2c0367c2bd2799ffe0089b209e731
2015-04-22 23:47:53 -04:00
Jenkins
15e0807256 Merge "Revert "Revert "Fix os_region_name in provider""" 2015-04-22 15:48:20 +00:00
Jenkins
5609850a57 Merge "Revert "Fix os_region_name in provider"" 2015-04-22 15:47:29 +00:00
Jenkins
b803a9a983 Merge "Revert "Move rabbit/kombu settings to oslo_messaging_rabbit section"" 2015-04-22 15:43:50 +00:00
Jenkins
a758389de6 Merge "MySQL: change default MySQL collate to utf8_general_ci" 2015-04-22 04:00:30 +00:00
Emilien Macchi
2f614cf9fd MySQL: change default MySQL collate to utf8_general_ci
Install & configure MySQL database by using utf8_general_ci collation
which is the way documented in OpenStack [1] and already the default
in puppetlabs-mysql [2].

[1] http://goo.gl/GA5gyZ
[2] https://github.com/puppetlabs/puppetlabs-mysql/blob/master/manifests/db.pp#L7

Change-Id: If85731786a061aed9cb44f016edc67f32c3db1a5
Closes-bug: #1446375
2015-04-21 18:53:13 -04:00
Emilien Macchi
79d307044a Beaker tests
Implement basic structure for beaker tests.

Change-Id: Ibfe041a7f500502ce357981a7ef917d1ce2a1760
Closes-bug: #1444736
2015-04-20 17:44:38 -04:00
Jenkins
eaddd54d8a Merge "Synchronize LICENSE file with OpenStack projects" 2015-04-20 14:26:33 +00:00
Emilien Macchi
aa19066721 Synchronize LICENSE file with OpenStack projects
Update LICENSE file to be the same as other OpenStack projects.

Closes-bug: #1241725
Change-Id: Ibbf55c931aee620cd785e382873b1b6b72bc18d4
2015-04-20 09:05:59 -04:00
Colleen Murphy
62c42a5f61 Revert "Revert "Fix os_region_name in provider""
Depends on https://review.openstack.org/#/c/174969/

This reverts commit e2301958e9dd4086fb6f5689499e5bb39e87e208.

Change-Id: I86db306b90cfdba53cf40bd9e3b2cce453e821d0
2015-04-17 17:43:49 -07:00
Colleen Murphy
e2301958e9 Revert "Fix os_region_name in provider"
When we revert the change that moved os_region_name, we must also
revert this fix that resulted from that change.

Depends on https://review.openstack.org/#/c/174968/

This reverts commit 354ae692a502a6089f4f82b3b58ee2aaa42443a2.

Change-Id: I65249b0734ae1a1bfbf0e5e153d19787f6aded5f
2015-04-17 17:42:37 -07:00
Jenkins
c0feafd0e9 Merge "Revert "Separate api and registry packages for Red Hat"" 2015-04-17 18:48:10 +00:00
Colleen Murphy
d302170d26 Revert "Move rabbit/kombu settings to oslo_messaging_rabbit section"
This reverts commit e6e8f6a56231409028ff1e7cdcd44781ca37d5b0.

Kilo deprecates these settings, but they still work. We should wait to
merge this until upstream distro packages are ready so that master is
not broken.

Change-Id: Ib05943e89969eb810527943426c566cf4a77e7ad
2015-04-17 17:13:52 +00:00
Emilien Macchi
876e857b29 Revert "Separate api and registry packages for Red Hat"
Due to a patch in RDO packaging, puppet-glance is broken for RHEL platforms.

This reverts commit 5f15e05704b2e549b8fab1c643a6ee743a0e92f4.

Change-Id: I7ba146714d1b0e8d461c556eff5a9f8c4ad9627f
2015-04-17 13:37:04 +00:00
Javier Pena
354ae692a5 Fix os_region_name in provider
Commit e6e8f6a56231409028ff1e7cdcd44781ca37d5b0 changed the section
where the os_region_name setting is placed from 'DEFAULT' to
'glance_store'. However, the provider was not updated to reflect
this change, so it broke.

Change-Id: I9e91faac2a45ac4eba4cc27c328e8dc67e619ab3
2015-04-16 18:39:08 +02:00
Jenkins
3f07c87f88 Merge "Change location to be a param, not a property" 2015-04-16 14:00:28 +00:00
Jenkins
9c1b0a90d9 Merge "Separate api and registry packages for Red Hat" 2015-04-16 08:51:01 +00:00
Colleen Murphy
c49cf8dbaa Pin puppetlabs-concat to 1.2.1 in fixtures
Puppet Labs is in the process of releasing a 2.0.0 version of
puppetlabs-concat, which will have many breaking changes that affect
many dependent modules. Changes have been merged to master, but not yet
released. While we figure out what changes we need to make in our own
modules and wait for updates in dependent modules, we should just pin
to a stable version.

Change-Id: Ie53c9c0c3f7ad84d310372e24eacc02a710cacf5
2015-04-15 15:25:52 -07:00
Jenkins
25ad0bfbbc Merge "Move rabbit/kombu settings to oslo_messaging_rabbit section" 2015-04-14 18:40:24 +00:00
Colleen Murphy
1d0a8ba83d Change location to be a param, not a property
The location property of the glance_image type has nearly identical
functionality as the source param, yet one is a param and one is a
property. It is possible to change either of these for a glance image,
but only if it is as of yet unset, and therefore unsaved. It is not
possible to change the location of a glance image once it has been
saved, nor is it possible to query it afterward. Since having location
be a property when it is usually unsettable and is always unqueryable
does not make much sense, we change it to be a param to be consistent
with the source param.

Change-Id: I686c3fec9bf571d18e282888c626d795c9958a6b
2015-04-10 15:18:34 -07:00
Javier Pena
5f15e05704 Separate api and registry packages for Red Hat
Starting in Kilo, Red Hat-based platforms are using separate
glance-api and glance-registry packages (for an example, see
http://trunk.rdoproject.org/f21/current/).

Change-Id: I3ad476846d7dec3ca612e5b0d20b21b8577f4af0
2015-04-10 18:07:12 +02:00
Jenkins
067ba2150a Merge "Fix API/Registry ensure for Ubuntu" 2015-04-10 15:26:20 +00:00
Matt Fischer
81a9c1acb1 Fix API/Registry ensure for Ubuntu
On Ubuntu the API and Registry are separate packages so we need an
package_ensure for each.

Change-Id: I02dcca223f57392e7b4c82806a2c0d48d301d4aa
2015-04-10 08:29:43 -06:00
Yanis Guenane
ab054853e1 Create a sync_db boolean for Glance.
Other components offer the option to decide whether or not to run the db sync
command. Glance was missing this feature. This commit add this feature for
Glance.

Change-Id: Iec31d724370a40aee56ead5839ef47ceacf7223d
2015-04-07 11:52:26 +02:00
Mike Dorman
e6e8f6a562 Move rabbit/kombu settings to oslo_messaging_rabbit section
Kilo oslo-messaging deprecates rabbit/kombu settings in the
DEFAULT section.

Move these settings to proper oslo_messaging_rabbit section.

Change-Id: Ica8cd70ece41f55b827f74d3f14cbc35f37ae13d
2015-04-02 22:54:42 -06:00
Xingchao Yu
101ca5b088 Move rbd related options into glance_store section
From Juno release, rbd related options has been move into
glance_store section.
See more info:
http://docs.openstack.org/juno/config-reference/content/section_glance-api.conf.html

Change-Id: Ibf38ee27f0ad08592dd05650c37613cee0100a7d
Closes-Bug: #1436699
2015-03-26 14:48:46 +08:00
Jenkins
0eed538b35 Merge "Fix catalog compilation when not configuring endpoint" 2015-03-19 23:29:32 +00:00
Emilien Macchi
ec48075eca api: change default pipeline
Setting up cache requires ops to be aware of how cache works in Glance
and the fact they'll need more space on disk. It can be dangerous when
using shared storage (Ceph for example).

This patch aims to default to 'keystone' without cachemanagement
anymore.

This is not backward compatible, so if the deployer is not overriding
this parameter, Glance API won't manage the cache anymore.

Change-Id: Ibac35501658b2ba79081cbc7a53245d4a4eb7839
2015-03-17 15:45:46 -04:00
Jenkins
2c9b22a668 Merge "Add $notification_driver parameter to notify::rabbitmq" 2015-03-16 08:17:55 +00:00
Jenkins
7aa1e3ecf9 Merge "Command parameter to sync the correct Database" 2015-03-13 16:23:50 +00:00
Bartłomiej Piotrowski
9be4c24d98 Add $notification_driver parameter to notify::rabbitmq
It makes possible to control the value of notification_driver setting and defaults
to 'messaging' to maintain backwards compatibility.

Change-Id: I3f2c29adbfb605ef288962f72ba81c11811cb357
2015-03-12 09:45:40 +01:00
Risto Laurikainen
ee0549f15d Fix catalog compilation when not configuring endpoint
Previously when you set $configure_endpoint to false and did not have a
keystone_endpoint resource with the same name as is defined by
glance::keystone::auth, the catalog would not be compiled. This was
because a relationship was being established where one resource in the
relationship didn't exist.

This changes this so that the relationship involving the Keystone
endpoint is only defined if $configure_endpoint is set to true.

Also, the test for when $configure_endpoint is false was set to check
for an endpoint that doesn't get created even if $configure_endpoint is
true. Fixed so that it checks for an endpoint that has the correct name
(the same as when using the default values to call the class).

Change-Id: I6631a656a888d0df7ab173705bea0598bd2b2f58
Closes-Bug: 1368686
2015-03-11 21:33:39 +01:00
Jenkins
c114412c36 Merge "spec: updates for rspec-puppet 2.x and rspec 3.x" 2015-03-11 17:12:02 +00:00
Jenkins
39a7cdde5c Merge "Fix lint issues (doc, metadata, manifests)" 2015-03-11 17:08:22 +00:00
Javier Pena
9f44421ceb Support identity_uri in provider
After https://review.openstack.org/152321 was merged, it was no
longer guaranteed that some now deprecated settings like auth_host
and auth_protocol would be present in glance-api.conf. This breaks
the Glance provider, which expects them to be present.

This patch adds support for identity_uri in provider, while
keeping backwards compatibility.

Change-Id: Ie8a2e45a4afea4828e02af36e64d65e7d4b7557e
2015-03-03 16:42:09 +01:00
Sebastien Badia
dbe297b056 spec: updates for rspec-puppet 2.x and rspec 3.x
This patch aim to update our specs test in order to work with the rspec-puppet release
2.0.0, in the mean time, we update rspec syntax in order to be prepared
for rspec 3.x move.

In details:

  * Use shared_examples "a Puppet::Error" for puppet::error tests
  * Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x)
  * Fix spec tests for rspec-puppet 2.0.0
  * Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
  * Clean Gemfile (remove over-specificication of runtime deps of puppetlabs_spec_helper)

Change-Id: Ibd0333dc3c0959e846edfbad51fb48e8dfb8fbe9
Card: https://trello.com/c/eHXc1Ryd/4-investigate-the-necessary-change-to-be-rspec-puppet-2-0-0-compliant
2015-02-25 05:37:44 +01:00