openstack/puppet-ironic
Code Issues Proposed changes

Merge "Add support for [neutron] fail_on_port_binding_failure"

Browse Source
This commit is contained in:
Zuul
2025-08-04 08:17:53 +00:00
committed by Gerrit Code Review
parent f4eb838b55 dd2c767c49
commit 1c9b2b5596
3 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
manifests/neutron.pp
View File

@@ -61,6 +61,10 @@
# successfully lease addresses.
# Defaults to $facts['os_service_default']
#
# [*fail_on_port_binding_failure*]
# (Optional) Fail deployment if neutron port binding fails.
# Defaults to $facts['os_service_default']
#
class ironic::neutron (
$password,
$auth_type = 'password',
@@ -73,6 +77,7 @@ class ironic::neutron (
$region_name = $facts['os_service_default'],
$endpoint_override = $facts['os_service_default'],
$dhcpv6_stateful_address_count = $facts['os_service_default'],
$fail_on_port_binding_failure = $facts['os_service_default'],
) {
if is_service_default($system_scope) {
@@ -95,5 +100,6 @@ class ironic::neutron (
'neutron/region_name': value => $region_name;
'neutron/endpoint_override': value => $endpoint_override;
'neutron/dhcpv6_stateful_address_count': value => $dhcpv6_stateful_address_count;
'neutron/fail_on_port_binding_failure': value => $fail_on_port_binding_failure;
}
}

5
releasenotes/notes/neutron-fail_on_port_binding_failure-e55b4311d8a09f69.yaml Normal file
View File

@@ -0,0 +1,5 @@
---
features:
- |
The new ``ironic::neutron::fail_on_port_binding_failure`` parameter has
been added.

3
spec/classes/ironic_neutron_spec.rb
View File

@@ -34,6 +34,7 @@ describe 'ironic::neutron' do
is_expected.to contain_ironic_config('neutron/region_name').with_value('<SERVICE DEFAULT>')
is_expected.to contain_ironic_config('neutron/endpoint_override').with_value('<SERVICE DEFAULT>')
is_expected.to contain_ironic_config('neutron/dhcpv6_stateful_address_count').with_value('<SERVICE DEFAULT>')
is_expected.to contain_ironic_config('neutron/fail_on_port_binding_failure').with_value('<SERVICE DEFAULT>')
end
context 'when overriding parameters' do
@@ -48,6 +49,7 @@ describe 'ironic::neutron' do
:region_name => 'regionTwo',
:endpoint_override => 'http://example2.com',
:dhcpv6_stateful_address_count => 8,
:fail_on_port_binding_failure => true,
)
end
@@ -62,6 +64,7 @@ describe 'ironic::neutron' do
is_expected.to contain_ironic_config('neutron/region_name').with_value(params[:region_name])
is_expected.to contain_ironic_config('neutron/endpoint_override').with_value(params[:endpoint_override])
is_expected.to contain_ironic_config('neutron/dhcpv6_stateful_address_count').with_value(params[:dhcpv6_stateful_address_count])
is_expected.to contain_ironic_config('neutron/fail_on_port_binding_failure').with_value(true)
end
end