1047 Commits

Author SHA1 Message Date
Takashi Kajinami
e8d678c465 Revert "CentOS 9: Disable unit tests dependent on puppet-postgresql"
This reverts commit f4a4d65822f08dd8977a50cd3e50178ec0960c91.

Reason for revert:
puppet-postgresql 8.1.0 was released and now the module supports RHEL 9
(and CentOS 9 effectively).

Note:
This change adds the service_provider fact in test fact data because
it is required by puppet-postgresql.

Depends-on: https://review.opendev.org/850705
Change-Id: I30e0b9cd798fff3fff3b81d7355c3dda239e033d
2022-07-24 00:36:22 +09:00
Zuul
dccea77ddd Merge "Add acceptance tests for config management resources" 2022-07-15 19:36:52 +00:00
Takashi Kajinami
f3693d3e88 Fix wrong test description
The value with a white space should be accepted instead of being
rejected. This change fixes the wrong test case description and makes
sure the description explains what is actually tested.

Change-Id: I841df474bd0aa7a84f0b443d87d002c343971ebd
2022-07-15 11:44:50 +09:00
Zuul
bdf6b66ae1 Merge "Debian/Ubuntu: The staging driver package is not available" 2022-07-11 09:21:08 +00:00
Zuul
c0d821cc06 Merge "Ubuntu: Use ipxe.efi instead of snponly.efi in Focal" 2022-07-11 09:21:06 +00:00
Zuul
694123f01d Merge "Debian/Ubuntu: Fix wrong source path to copy efi file" 2022-07-11 08:31:48 +00:00
Takashi Kajinami
c9d42b14eb Add acceptance tests for config management resources
Change-Id: Ia3bc4839fbf39845e46ce2bdf62a365ef4e04146
2022-07-10 12:40:01 +09:00
Zuul
4e7226020a Merge "Debian/Ubuntu: Do not use the ironic-inspector-dnsmasq service" 2022-07-07 09:40:38 +00:00
Zuul
123ad82f7e Merge "Debian/Ubuntu: Fix installation of pxelinux.0 and syslinux files" 2022-07-07 09:34:18 +00:00
Zuul
9b0ab00b50 Merge "inspector: Use config file installed by the package" 2022-07-06 16:41:48 +00:00
Zuul
19b9ee4083 Merge "Debian/Ubuntu: Use tftpd-hpa instead of tftpd" 2022-07-06 16:41:43 +00:00
Zuul
dabcabf885 Merge "Remove redundant check of ironic-inspector package" 2022-07-06 16:41:40 +00:00
Zuul
663ebff977 Merge "Expose headers option of apache::vhost" 2022-07-06 16:08:44 +00:00
Takashi Kajinami
a92e08ecc2 Debian/Ubuntu: The staging driver package is not available
... so the deployment should fail the user explicitly requires it.

Change-Id: Ibd0fe69f2a2d0defb648d06e8098712f84de45e6
2022-07-04 03:10:50 +09:00
Takashi Kajinami
e905d9585e Ubuntu: Use ipxe.efi instead of snponly.efi in Focal
The ipxe package in Ubuntu 20.04(focal) does not provide snponly.efi
but only ipxe.efi. This change ensures that ipxe.efi is used by default
in Ubuntu 20.04. snponly.efi is available since 22.04(jammy) so we will
remove this fallback once we remove support for Ubuntu 20.04.

Change-Id: Iac9c4511f03eb0f5966458858c5d5fb530f85c6e
2022-07-04 03:10:46 +09:00
Takashi Kajinami
38c3def176 Debian/Ubuntu: Fix wrong source path to copy efi file
In Debian/Ubuntu, the efi file installed by the ipxe package is named
"snponly.efi" instead of "ipxe-snponly.efi". This fixes the wrong name
so that the file can be copied without error by default.

Change-Id: I1e8a2d12fee99e468eebf6afa040589803be039a
2022-07-04 02:30:48 +09:00
Takashi Kajinami
0d75b53663 Debian/Ubuntu: Do not use the ironic-inspector-dnsmasq service
... because the service is not available in these distributions.

Change-Id: I9b3db7f1749479c6581ada34117a31729572ecb9
2022-07-04 00:54:23 +09:00
Takashi Kajinami
b780aca649 Debian/Ubuntu: Fix installation of pxelinux.0 and syslinux files
Debian and Ubuntu requires the separate pxelinux package to use
the pxelinux.0 file and the file is stored in a separated directory.

Also, the current directory to locate the syslinux files are outdated
and does not work with the recent versions.

This change fixes these two problems.

Change-Id: I560b3b6af5b2bab0b1144aa1eda6088f01336d75
2022-07-04 00:54:19 +09:00
Takashi Kajinami
5fe5a0737f inspector: Use config file installed by the package
... instead of ensuring/creating the file.

Change-Id: Ifa76da52a75031ec767f374e6d33bd66315634d3
2022-07-03 22:34:29 +09:00
Takashi Kajinami
80307bece6 Debian/Ubuntu: Use tftpd-hpa instead of tftpd
The tftpd-hpa package possesses a number of bugfixes and enhancements
over the original tftpd package. Especially it supports the 'tsize'
which is required by PXE.

Change-Id: I41b95f80ed4d972a65f25541d2c5f4ae2df79d60
2022-07-03 22:30:34 +09:00
Takashi Kajinami
cfaf84837c Remove redundant check of ironic-inspector package
The ironic-inspector package is now available in all of the supported
operating systems, so it's redundant to check whether the package name
is defined.

Change-Id: Iae4467d1278df2f7ef82019013b23a3dea556201
2022-07-03 02:07:45 +09:00
Takashi Kajinami
1467a91e4f Expose headers option of apache::vhost
The headers option in apache::vhost is required in some case, for
example when adding the X-XSS-Protection header. This change allows
customizing the option for the api vhost.

This change also adds support for request_headers so that both request
headers and response headers can customized.

Change-Id: I11274e444c230c62210e2ed5c0f4811f019b16ae
2022-06-30 11:03:34 +09:00
Steve Baker
4863a485cd Copy shim and grub efi binaries to tftp root
Currently uefi_pxe_bootfile_name defaults to bootx86.efi, but puppet
doesn't copy any file to this location. This change copies the signed
grub shim efi to tftp root bootx86.efi, and also the signed grub
binary to grubx64.efi.

This means UEFI boot with PXE will now work by default by doing a grub
network boot instead of using iPXE. And since all EFI binaries are
signed, it should even be possible to enable Secure Boot for the whole
baremetal provisioning process.

Change-Id: I59850eca971d57464efe85ffea723f19f9855353
Closes-Bug: #1975543
2022-06-25 02:47:38 +00:00
Takashi Kajinami
8672adf57a Do not show diffs of image files
... because these are binary files and diffs are not really useful.

Change-Id: Ife95969ab90bdba3d3af55e021b7bd6b76f94b2c
2022-06-23 16:43:52 +00:00
Zuul
05ada3d17f Merge "Remove deprecated ironic::drivers::pxe::pxe_append_params" 2022-06-20 20:00:26 +00:00
Zuul
0c26669f26 Merge "conductor: Clean up inspect_timeout" 2022-06-20 20:00:23 +00:00
Zuul
ad92b77031 Merge "conductor: Remove configdrive_use_swift" 2022-06-20 19:31:28 +00:00
Zuul
024b60d1a5 Merge "conductor: Remove deprecated api_url" 2022-06-20 19:31:26 +00:00
Zuul
610ad76445 Merge "Remove deprecated ironic::pxe::enable_ppc64le" 2022-06-20 19:26:36 +00:00
Takashi Kajinami
531ee79aed conductor: Clean up inspect_timeout
... because the parameter was deprecated during Victoria cycle[1] in
favor of the new inspect_wait_timeout parameter.

[1] 19851a4d625712b3bf3c8252161c2a858fece941

Change-Id: I2f3e2468f3552dfcc1ffe7d35b504a474966593a
2022-06-20 08:08:25 +09:00
Takashi Kajinami
37b2d997a8 conductor: Remove configdrive_use_swift
... because it was deprecated during Victoria cycle[1] in favor of
the configdriver_use_object_store parameter.

[1] 73d39c09c11399a04f270f1c41fb12ac6225a417

Change-Id: I31f995aa13931bbcd400e7806dcfe583a9244141
2022-06-20 08:06:31 +09:00
Takashi Kajinami
1b9c0360f4 Remove deprecated ironic::drivers::pxe::pxe_append_params
... because the parameter was deprecated during Xena cycle by [1].

[1] 541157fe290e6b9ce6923e968692e6cf23eb7109

Change-Id: I918fdab05117c36a3a78d1b7501416cc6a2793d3
2022-06-19 22:33:41 +09:00
Takashi Kajinami
818b8ce831 conductor: Remove deprecated api_url
... because the parameter was deprecated during Ussuri cycle[1].

[1] 305964417d6e3de26bf4582a0ecac77294c40a9e

Change-Id: I67b4294993807599f61c4c5eef353f2d97cbccc5
2022-06-19 22:23:24 +09:00
Takashi Kajinami
bb8eadfa3c Remove deprecated ironic::pxe::enable_ppc64le
... because the parameter was deprecated during Yoga cycle[1].

[1] f1aefe228afeab456cbe547e79217870ed4a321b

Change-Id: I080d1a7029b13245d33334ae11a42f7d787da172
2022-06-19 22:18:17 +09:00
Rajesh Tailor
a455ce650c Fix typos in parameter descriptions, comments and tests
Change-Id: I4b4671a38e482b74faa4e48ff244c2a08e4b094e
2022-06-17 18:55:52 +05:30
Zuul
4564c08992 Merge "Refactor unit tests of ironic::pxe" 2022-06-13 19:46:49 +00:00
Zuul
68483e6d8d Merge "Use native implementation to add listen for apache vhost" 2022-06-10 11:55:29 +00:00
Takashi Kajinami
aab3ad2630 Refactor unit tests of ironic::pxe
This refactors unit tests of the ironic::pxe class according to
the following points.

- Chainload image resource should be tested with default parameters

- Make sure package resources are included

- The resource title for syslinux-tftpboot package is syslinux, instead
  of syslinux-tftpboot.

- 'default_params' and 'p' are not used

Change-Id: Ibb1d9b232303c536019e95fc17b3619c791553d4
2022-06-02 10:42:11 +09:00
Takashi Kajinami
a612ff0b67 Use native implementation to add listen for apache vhost
Currently the vhost management in ironic::pxe has its own logic to
inject the Listen option into the vhost configuration file instead of
the core apache configuration file but these two should be effectively
same as long as vhosts are properly configured.

Because we globally use the implementation in puppetlabs-apache which
adds Listen to the core file, this replaces own mechanism by that
existing implementation to simplify the own logics.

Change-Id: I1e979159116f25a404b5f081c02352a6f2412074
2022-06-02 09:45:35 +09:00
Takashi Kajinami
74b999f28d Remove support for CentOS 8 Stream
... because RDO will provide packages for only CentOS Stream 9 for Zed
release. This change removes RHEL 8 as well.

Depends-on: https://review.opendev.org/843503
Change-Id: I4f957e4d54ec801510941fd7fd0e718f5f41c561
2022-06-01 13:46:56 +09:00
Takashi Kajinami
c317250f96 apache+mod_wsgi: Disable SSL by default
During the previous cycle, a warning message was added to inform users
of this change.

Now the default value is updated so that SSL is disabled by default.

Change-Id: If565fecd8919d0a34c0b6b3009b7623610e78065
2022-05-06 20:48:35 +09:00
Zuul
5c2b59e46c Merge "Remove deprecated parameters to override endpoint url" 2022-04-22 16:21:40 +00:00
Takashi Kajinami
2a0d0df13a Remove deprecated parameters to override endpoint url
These parameter were deprecated during Train cycle by [1] and have been
ineffective since then.

[1] fb8e19deb88c4e244dded10d660f9aa81792c54b

Change-Id: Ib2e2f8284a61ae7f8a1ae75a2b2c0a63503ddc08
2022-04-21 15:22:01 +09:00
Takashi Kajinami
7135cf3f0c Remove deprecated ipxe_enable parameter
This parameter was deprecated during Xena cycle[1] and has had no
effect since then.

[1] 3864e15998b5b1eec7d2b1b4911add9bb899fdb8

Change-Id: Ic384acfb6b2186f6805a7e704c13e318721c1125
2022-04-21 13:44:57 +09:00
Takashi Kajinami
98c9b5c81b Inspector: Fix missing log-facility when tftp protocol is used
Closes-Bug: #1968937
Change-Id: I4bfa487e6c982c99314112a58da61d6e53935b90
2022-04-14 09:21:21 +09:00
69ca2766c4 Update master for stable/yoga
Add file to the reno documentation build to show release notes for
stable/yoga.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/yoga.

Sem-Ver: feature
Change-Id: Ic6e814bad9ba8ba7d74543fcbe0f41d5c47f55a2
2022-04-05 09:11:07 +00:00
Jiri Podivin
58f113cba1 setuptools: Disable auto discovery
The latest release of setuptools 61.0 made a breaking change[1] and
because of this change 'pip install' fails with the following error.

~~~
error: Multiple top-level packages discovered in a flat-layout:
['lib', 'spec', 'manifests', 'releasenotes'].
~~~

Users that don't set 'packages', 'py_modules', or configuration'
are still likely to observe the auto-discovery behavior, which may
halt the build if the project contains multiple directories and/or
multiple Python files directly under the project root.

To disable auto discovery, one can do below in setup.py

~~~
setuptools.setup(..,packages=[],..)
~~~

or

~~~
setuptools.setup(..,py_modules=[],..)
~~~

[1] https://github.com/pypa/setuptools/issues/3197

Note setup.py is not used to install puppet modules. However it is used
to generate a release note, thus should be fixed.

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I9767330a94f2406a6e76be0f7ce3886478bce3e5
20.3.0
2022-03-29 10:39:09 +02:00
Zuul
32b71d347c Merge "Add support for [glance] swift_account_prefix" 2022-03-12 06:01:26 +00:00
Takashi Kajinami
6828e0c7d4 Prepare Yoga RC1
Change-Id: I51a91bdc70f7d0ffe84e60cae7f6835e15e02904
2022-03-12 00:40:02 +09:00
Takashi Kajinami
cd74ca4f31 Add support for [glance] swift_account_prefix
Depends-on: https://review.opendev.org/823913
Change-Id: Ie88c25c3722e850530f81d395e62f9e50093e7be
2022-03-11 22:44:22 +09:00