Commit Graph

915 Commits

Author SHA1 Message Date
Julia Kreger
f2dd0d3cc5 Support use of dnsmasq as tftp service
Switches to using the new ironic-dnsmasq-tftp-server service[1], which
manages the dnsmasq process in order to facilitate standalone usage and
testing of puppet-ironic outside with Centos-Stream 9 where package
changes are anticipated.

On Centos-Stream 9, users should effectively be forced over to using
dnsmasq automatically.

The higher level controls for defaults can also be changed for
the purpose of backporting such that prior releases are not
automatically switch to using dnsmasq unless they have to be run with
dnsmasq based upon known package availability.

Note that just setting tftp_use_xinetd=false in an existing deployment
doesn't remove the xinetd service completely, because of limitation
caused by current implementation of puppet-xinetd, and users are
responsible to remove service, package and etc properly before
switching to the new service.

[1] https://review.rdoproject.org/r/c/openstack/ironic-distgit/+/34691

Change-Id: I5d388acfb96fa3e3a555a119ff72feabdd1cdf87
2021-10-04 15:17:41 +00:00
Zuul
c5e8504355 Merge "Make usage of keystone::resource::service_identity consistent" 2021-10-02 13:42:43 +00:00
ZhongShengping
db754a7d7d Add information technology in the setup.cfg
Change-Id: I5e848ae96ac57beee53fd4ee798c93d04c39b077
2021-10-01 06:54:49 +08:00
ZhongShengping
ff788bc636 Add license information in the setup.cfg
Change-Id: Iff8af3fe96a19bc5d7ce723b80637ebdd7ad8184
2021-09-30 16:48:13 +08:00
ZhongShengping
c43a6d42bd Delete useless code for setup.py
Change-Id: Ic10e4ea7401f06bf51b5cf52572bf99787e55e51
2021-09-30 13:38:33 +08:00
Takashi Kajinami
de672ed967 Make usage of keystone::resource::service_identity consistent
This fixes usage of the keystone::resource::service_identity resource
type for ironic-inspector, currently inconsistent with the other
modules.

- The resource type is generally used with a static name

- Email account is same with the service name by default, not service
  type.

Change-Id: I4023cb66aca52c43f4c6b719267657e5cc0734c7
2021-09-30 10:00:54 +09:00
Zuul
464e5c8d6d Merge "Stop configuring install_command in tox." 2021-09-29 12:03:43 +00:00
Zuul
0a3af6291c Merge "Fix pbr>=2.0.0 for setup.py" 2021-09-29 09:08:58 +00:00
Takashi Kajinami
9b3c5b801b Stop configuring install_command in tox.
It turns out that this is the the default value provided by tox:

https://tox.readthedocs.io/en/latest/config.html#conf-install_command

So we can remove the line and simply use the default value.

Change-Id: I58a57d1ca589af99cfcf3d351b3acfba1ee04669
Co-Authored-By: tushargite96 <tushargite96@gmail.com>
2021-09-29 18:03:53 +09:00
ZhongShengping
8155688108 Fix pbr>=2.0.0 for setup.py
Change-Id: I57b10ded3e4d79b0c1744de6a5ea1065a1ef85d0
2021-09-29 16:37:10 +08:00
ZhongShengping
b95e9a4aeb Update openstackdocstheme to the latest version
Change-Id: I324e0cbeb5f0fa361d5c653c30c586c4dfccc161
2021-09-29 16:06:50 +08:00
Zuul
dcb82a4bff Merge "Update reno to the latest version" 2021-09-28 10:31:07 +00:00
Zuul
f96801b70a Merge "Do not test detail of keystone::resource::service_identity" 2021-09-28 10:31:06 +00:00
Zuul
ba39bf3d9c Merge "Skip dependency on keystone endpoint of endpoint is not configured" 2021-09-28 10:31:04 +00:00
ZhongShengping
1392801ea8 Update reno to the latest version
Change-Id: I29bd9e1d697c17e0f08918ae7ce01ba99e595e66
2021-09-28 17:14:35 +08:00
Zuul
affcb980a9 Merge "Rename pxe_append_params" 2021-09-27 13:31:44 +00:00
Takashi Kajinami
074b7fce7c Do not test detail of keystone::resource::service_identity
... but test interfaces of that resource type. This helps us avoid
direct breakage caused by any change in puppet-keystone.

Change-Id: Icafdac7a8f2e0184f296203177e48f2910ede66e
2021-09-27 22:18:58 +09:00
Takashi Kajinami
827d3fe148 Skip dependency on keystone endpoint of endpoint is not configured
Change-Id: I96863c199ee7095f853acf239c1c651bd0ca341f
2021-09-27 21:40:26 +09:00
Zuul
98894d98c2 Merge "Fix unit tests incompatible with puppetlab-stdlib 8.0.0" 2021-09-23 18:18:27 +00:00
Takashi Kajinami
4fa9f61485 Fix unit tests incompatible with puppetlab-stdlib 8.0.0
Since puppetlabs-stdlib 8.0.0, ensure_packages automatically translates
'ensure => present'  to 'ensure => installed' and that translation
breaks existing assertions in unit tests.

Change-Id: I09aa9cc8d7b3294e6f2d6aa97d33600a54615b63
2021-09-24 00:26:45 +09:00
ZhongShengping
4c990c7da8 Fix stdlib version in metadata
puppetlabs-stdlib is now using the 8.0.0 version, so we should fix the
stdlib version in metadata.

Change-Id: Ia424b359eb925947377d0d54b84479295afd20b1
2021-09-23 19:44:22 +08:00
Takashi Kajinami
541157fe29 Rename pxe_append_params
... to follow the renaming in ironic during the Xena cycle[1].

[1] 2a73f5a84e06b370d0b04997cc0787497e111642

Change-Id: I0026b3f47cb3e0caefa0f299ee5e7e4bf9a4e890
2021-09-22 22:44:47 +09:00
Zuul
4b790c23b0 Merge "Allow purging policy files" 2021-09-20 08:30:26 +00:00
Zuul
eb26414d5e Merge "inspector: Add support for healthcheck middleware" 2021-09-20 08:30:25 +00:00
Takashi Kajinami
6ab4dfe25d inspector: Add support for healthcheck middleware
This change introduces support for parameters of the healthcheck
middleware, which was introduced recently to ironic-inspector.

Depends-on: https://review.opendev.org/808567
Change-Id: If77a1a6b60268379a5e87165aa6c93c6c4d40770
2021-09-17 19:35:04 +09:00
ZhongShengping
e8a35dd55a Prepare Xena RC1
Update the version metadata for Xena milestone RC1

Change-Id: Ie688ef1f470b2a9576e21578df7a2b04a00d7d64
2021-09-17 17:36:09 +08:00
Zuul
3ca41898ca Merge "inspector dnsmasq: make sequential-ip configurable" 2021-09-15 17:53:58 +00:00
ZhongShengping
8129e85eac Add watch_log_file option
Add support for Using logging handler designed to watch file system.

Change-Id: Ifc04c0975a537831bc45ba7eaba27ccebf2a7b77
Closes-Bug: #1943212
2021-09-14 16:02:09 +08:00
Zuul
84504f3103 Merge "Prepare Xena M3" 2021-09-09 16:16:17 +00:00
Zuul
77996ea30d Merge "Remove default hardware type override" 2021-09-07 16:34:30 +00:00
Zuul
a4c67d9941 Merge "Accept string value for enabled_hardware_types" 2021-09-07 16:34:29 +00:00
Zuul
1d88995dfe Merge "json_rpc: Fix the default project_name" 2021-09-07 16:30:07 +00:00
ZhongShengping
1993e8f817 Prepare Xena M3
Update the version metadata for Xena milestone M3

Change-Id: I12e8fa6866f2b7f148632573b71c65b4c123c7a2
2021-09-06 15:32:08 +08:00
Takashi Kajinami
ff5f16600a Allow purging policy files
This change introduces the new purge_config parameter to the policy
class so that any policy rules not managed by puppet manifests can be
cleared.

Co-Authored-By: Martin Schuppert <mschuppert@redhat.com>
Depends-On: https://review.opendev.org/802305
Change-Id: Ia5fecab4cb81dda87766b950433cdad3ce75b9eb
2021-09-05 01:21:34 +09:00
Zuul
17eb103f4a Merge "Do not test authtoken parameters directly" 2021-09-03 09:32:29 +00:00
Zuul
777bcbc7d3 Merge "Use a 'params' hash for authtoken parameters" 2021-09-03 09:32:28 +00:00
Zuul
9efa9c818c Merge "Remove unnecessary workaround for missing ipmitool dependency" 2021-09-02 18:28:10 +00:00
Harald Jensås
4f67b341ee inspector dnsmasq: make sequential-ip configurable
Add the parameter ``dnsmasq_dhcp_sequential_ip`` to the
ironic::inspector class. When true (the default) dnsmasq
is configured to serve addresses in sequential orders.

Some DHCPv6 clients don't operate well with a DHCP server
that serves addresses sequentially. The new parameter
allow disabling sequential addressing to improve
interoperability with DHCPv6 clients in UEFI firmware.

Closes-Bug: #1941908
Change-Id: Iad32434790a1744249b284937c6b67e9b58a235f
2021-08-28 08:53:36 +09:00
Takashi Kajinami
0c396db86c json_rpc: Fix the default project_name
In Puppet OpenStack modules, the "services" project is widely used as
the default project name. This change fixes the inconsistent default
value used.

Closes-Bug: #1941900
Change-Id: Ia10665056ad521ccb3a81c4490831da78bb5c45a
2021-08-28 00:07:50 +09:00
Takashi Kajinami
3cabf75eb6 Do not test authtoken parameters directly
The authtoken parameters are not managed directly but managed by
the keystone::resource::authtoken class. Thus we should avoid testing
parameters directly otherwise any change in the resource type can
cause test failures.

Change-Id: I162cea3b64e6c933f0c605e14ab8820f218b87ac
2021-08-27 15:05:47 +09:00
Takashi Kajinami
40e185a170 Use a 'params' hash for authtoken parameters
This change adds the 'params' hash in authtoken class, to implement
the same functionality as the one recently introduced into
puppet-nova[1].

[1] 5c38281e1b698f157f03bf1815733277c541c30b

Change-Id: I55cae48368653150aaa50e5b167c6fb11cf551e2
2021-08-27 14:42:39 +09:00
Julia Kreger
263afe8e6b Remove default hardware type override
Puppet-ironic ships with only the ipmi hardware type enabled.

This setting is possibly the most commonly overriden setting
used by operators and also prohibits the community determiend
default form just being used, which creates a friction point
between the two projects.

As such, it makes sense to remove, and just allow ironic's
default to be leveraged, by default.

Change-Id: I26b9eabd4c58b702ed18d6e8e21bd938908905a9
2021-08-27 12:59:25 +09:00
Takashi Kajinami
f761d8dc1e Accept string value for enabled_hardware_types
... to follow the existing standards to manage options defined as
ListOpt.

Change-Id: I734eb947b4d57828ca4de00ed90776ecbe6379bc
2021-08-27 12:57:49 +09:00
Takashi Kajinami
5ac602f851 Remove unnecessary workaround for missing ipmitool dependency
... because the dependency was already added in UCA[1].

[1] https://bugs.launchpad.net/cloud-archive/+bug/1572800

Change-Id: I5c09ddee31f04df51a47d47d41c4d91505a7d5d4
2021-08-27 12:54:17 +09:00
Julia Kreger
78f7e9efb7 Deprecate bifrost support
My downstream team does not maintain this and the settings
which are embedded and encoded in puppet-ironic are incorrect
and no longer match the current state of Bifrost as an independent
sub-project of ironic.

Given this state, and the fact it is largely independent tooling
which duplicates much of puppet-ironic, it does not make sense to
maintain, and is thus deprecated.

Change-Id: Ia456fcea46c44c23d8c99fbf3bb59b63180a28f2
2021-08-26 16:19:13 -07:00
Zuul
e4cc88ec8d Merge "Ensure tftp root directory is created" 2021-08-23 17:18:36 +00:00
Takashi Kajinami
0112497161 Ensure tftp root directory is created
... before creating any file under the directory.

Change-Id: I549d2217668d84f170b5c7a989c2acf2b9a0e16a
2021-08-22 21:58:23 +09:00
Arne Wiebalck
9e2422cc4e Expose sync_power_state_workers
The sync_power_state_workers parameter allows to tune the parallelism
in BMC connections when getting the power state. This may be needed to
cope with misbehaving BMCs or IPMI power status failures due to UDP
packet loss.

Change-Id: I48e3f36115825f620dfc924fe097cdce92deb80d
2021-08-20 10:21:46 +02:00
Zuul
faf7f53864 Merge "Deprecate invalid ironic_api_paste_ini" 2021-08-19 22:13:26 +00:00
Zuul
2dfba43f8a Merge "Fix the wrong function name" 2021-08-18 03:38:18 +00:00