openstack
/
puppet-keystone
Code Issues Proposed changes

Do not validate database_connection format 

Currently we validate database_connection in 2 layers, each puppet
modules and puppet-oslo, however this makes it difficult to maintain
validation pattern because we always need to fix both.
This patch removes the validation from each puppet modules so that
we need to maitain only one place, puppet-oslo to update validation
logic.

Change-Id: I18ec317bf44983a08b1d428aeeae65e6c77e326c
This commit is contained in:
Takashi Kajinami 2020-08-31 17:50:07 +09:00
parent f342aad946
commit 187deb268c
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manifests/db.pp
View File

@ -61,9 +61,6 @@ class keystone::db (
$database_retry_interval_real = pick($::keystone::database_retry_interval, $database_retry_interval)
$database_max_overflow_real = pick($::keystone::database_max_overflow, $database_max_overflow)
validate_legacy(Oslo::Dbconn, 'validate_re', $database_connection_real,
['^(sqlite|mysql(\+pymysql)?|postgresql(\+psycopg2)?):\/\/(\S+:\S+@\S+\/\S+)?'])
oslo::db { 'keystone_config':
db_max_retries => $database_db_max_retries,
connection => $database_connection_real,