logging: Deprecate watch_log_file

This option was deprecated in oslo.log 6.0.0 [1]. Because the warning
to catch usage of the parameter is implemented in the underlying
oslo::log defined resource type, no additional warning message is
implemented in this module.

[1] https://review.opendev.org/914788

Depends-on: https://review.opendev.org/930126
Change-Id: I6cf672931bded189456d7cd7ea446c6e995ef5ef

manifests/logging.pp

@@ -106,9 +106,11 @@
 #   Defaults to $facts['os_service_default']
 #   Example: 'Y-%m-%d %H:%M:%S'
 #
+# DEPRECATED PARAMETERS
+#
 # [*watch_log_file*]
 #   (Optional) Uses logging handler designed to watch file system (boolean value).
-#   Defaults to $facts['os_service_default']
+#   Defaults to undef
 #
 class keystone::logging(
   $use_syslog                    = $facts['os_service_default'],
@@ -131,7 +133,8 @@ class keystone::logging(
   $instance_format               = $facts['os_service_default'],
   $instance_uuid_format          = $facts['os_service_default'],
   $log_date_format               = $facts['os_service_default'],
-  $watch_log_file                = $facts['os_service_default'],
+  # DEPRECATED PARAMETERS
+  $watch_log_file                = undef,
 ) {
 
   include keystone::deps

releasenotes/notes/deprecate-watch_log_file-7234190eda04ee81.yaml

@@ -0,0 +1,4 @@
+---
+deprecations:
+  - |
+    The ``keystone::logging::watch_log_file`` parameter has been deprecated.