openstack/puppet-keystone
Code Issues Proposed changes

Remove redundant installation of python3-pysaml2

Browse Source 
The python3-pysaml2 package is required by the python3-keystone package
so we don't have to install it explicitly.

Change-Id: I1ed978e55774637abcddaec91f36c6b5d3c473eb
This commit is contained in:
Takashi Kajinami
2023-05-15 19:32:20 +09:00
parent 6c2a161721
commit 3c86a14ddb
3 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
manifests/federation/identity_provider.pp
View File

@@ -108,12 +108,6 @@ class keystone::federation::identity_provider(
tag => 'keystone-support-package',
}
package{ 'python-pysaml2':
ensure => $package_ensure,
name => $keystone::params::python_pysaml2_package_name,
tag => 'keystone-support-package',
}
keystone_config {
'saml/certfile': value => $certfile;
'saml/keyfile': value => $keyfile;

2
manifests/params.pp
View File

@@ -19,7 +19,6 @@ class keystone::params {
$keystone_wsgi_script_path = '/usr/lib/cgi-bin/keystone'
$python_memcache_package_name = 'python3-memcache'
$python_ldappool_package_name = 'python3-ldappool'
$python_pysaml2_package_name = 'python3-pysaml2'
}
'RedHat': {
$package_name = 'openstack-keystone'
@@ -27,7 +26,6 @@ class keystone::params {
$keystone_wsgi_script_path = '/var/www/cgi-bin/keystone'
$python_memcache_package_name = 'python3-memcached'
$python_ldappool_package_name = 'python3-ldappool'
$python_pysaml2_package_name = 'python3-pysaml2'
}
default: {
fail("Unsupported osfamily: ${facts['os']['family']}")

5
spec/classes/keystone_federation_identity_provider_spec.rb
View File

@@ -41,11 +41,6 @@ describe 'keystone::federation::identity_provider' do
:ensure => 'present',
)}
it { is_expected.to contain_package('python-pysaml2').with(
:ensure => 'present',
:name => platform_params[:python_pysaml2_package_name],
)}
it {
is_expected.to contain_keystone_config('saml/certfile').with_value(params[:certfile])
is_expected.to contain_keystone_config('saml/keyfile').with_value(params[:keyfile])