openstack/puppet-murano
Code Issues Proposed changes

[rabbit] password should be secret

Browse Source 
... because the option accepts a password string used to connect
a RabbitMQ server.

Change-Id: I3da360119a9dc347fc90affc445256866f421741
This commit is contained in:
Takashi Kajinami 2023-09-11 13:32:18 +09:00
parent 840927a91c
commit b93b0cac80
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/init.pp
View File

@ -322,7 +322,7 @@ class murano(
'engine/use_trusts' : value => $use_trusts;
'rabbitmq/login' : value => $rabbit_own_user;
'rabbitmq/password' : value => $rabbit_own_password;
'rabbitmq/password' : value => $rabbit_own_password, secret => true;
'rabbitmq/host' : value => $rabbit_own_host;
'rabbitmq/port' : value => $rabbit_own_port;
'rabbitmq/virtual_host' : value => $rabbit_own_vhost;

4
spec/classes/murano_init_spec.rb
View File

@ -51,7 +51,7 @@ describe 'murano' do
it { is_expected.to contain_murano_config('oslo_messaging_rabbit/amqp_durable_queues').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_murano_config('rabbitmq/login').with_value('guest') }
it { is_expected.to contain_murano_config('rabbitmq/password').with_value('guest') }
it { is_expected.to contain_murano_config('rabbitmq/password').with_value('guest').with_secret(true) }
it { is_expected.to contain_murano_config('rabbitmq/host').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_murano_config('rabbitmq/port').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_murano_config('rabbitmq/virtual_host').with_value('murano') }
@ -138,7 +138,7 @@ describe 'murano' do
it { is_expected.to contain_murano_config('oslo_messaging_rabbit/amqp_durable_queues').with_value(true) }
it { is_expected.to contain_murano_config('rabbitmq/login').with_value('murano') }
it { is_expected.to contain_murano_config('rabbitmq/password').with_value('secrete') }
it { is_expected.to contain_murano_config('rabbitmq/password').with_value('secrete').with_secret(true) }
it { is_expected.to contain_murano_config('rabbitmq/host').with_value('10.255.0.2') }
it { is_expected.to contain_murano_config('rabbitmq/port').with_value('5674') }
it { is_expected.to contain_murano_config('rabbitmq/virtual_host').with_value('murano_vhost') }