openstack/puppet-neutron
Code Issues Proposed changes

Move distro speicfic logic to params

Browse Source 
... instead of maintaining the logic in individual manifests.

Change-Id: I0658a32d6531c3cb524cccdffd634d3428e7bc31
This commit is contained in:
Takashi Kajinami 2024-01-08 21:35:47 +09:00
parent caadd595e3
commit 10a6fe1ec9
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/agents/ml2/ovs.pp
View File

@ -557,7 +557,7 @@ class neutron::agents::ml2::ovs (
}
Neutron_agent_ovs<||> ~> Service['neutron-ovs-agent-service']
if ($facts['os']['family'] == 'Redhat') {
if $::neutron::params::destroy_patch_ports_service {
# NOTE(tkajinam): The service should not be started in a running system.
# DO NOT define ensure so the service status is not
# changed.

3
manifests/params.pp
View File

@ -7,7 +7,6 @@ class neutron::params {
$client_package = 'python3-neutronclient'
$ovs_agent_service = 'neutron-openvswitch-agent'
$destroy_patch_ports_service = 'neutron-destroy-patch-ports'
$linuxbridge_agent_service = 'neutron-linuxbridge-agent'
$macvtap_agent_service = 'neutron-macvtap-agent'
$opencontrail_plugin_package = 'neutron-plugin-contrail'
@ -38,6 +37,7 @@ class neutron::params {
$ml2_server_package = 'openstack-neutron-ml2'
$ovs_agent_package = 'openstack-neutron-openvswitch'
$ovs_cleanup_service = 'neutron-ovs-cleanup'
$destroy_patch_ports_service = 'neutron-destroy-patch-ports'
$linuxbridge_agent_package = 'openstack-neutron-linuxbridge'
$sriov_nic_agent_service = 'neutron-sriov-nic-agent'
$sriov_nic_agent_package = 'openstack-neutron-sriov-nic-agent'
@ -95,6 +95,7 @@ class neutron::params {
$bgpvpn_bagpipe_package = 'python3-networking-bagpipe'
$ovs_agent_package = 'neutron-openvswitch-agent'
$ovs_cleanup_service = undef
$destroy_patch_ports_service = undef
$linuxbridge_agent_package = 'neutron-linuxbridge-agent'
$sriov_nic_agent_service = 'neutron-sriov-agent'
$sriov_nic_agent_package = 'neutron-sriov-agent'