openstack/puppet-neutron
Code Issues Proposed changes

Follow up "Support ovs/openflow_processed_per_port configuration option"

Browse Source 
This is follow-up of ebd50d6444 and
addresses the following points.

- Add missing release note
- Add unit test assertion of the new resource
- replace the hard-coded default by os_service_default fact to avoid
  additional maintenance effort to sync the default

Change-Id: I4de49c4ef317d086cff486e739365384e0d5f3c9
This commit is contained in:
Takashi Kajinami 2024-05-15 00:24:05 +09:00
parent ebd50d6444
commit 2890306d9b
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/agents/ml2/ovs.pp
View File

@ -272,7 +272,7 @@
# [*openflow_processed_per_port*] # [*openflow_processed_per_port*]
# (Optional) If enabled, all OVS OpenFlow rules associated to a port will be # (Optional) If enabled, all OVS OpenFlow rules associated to a port will be
# processed at once, in one single transaction. # processed at once, in one single transaction.
# Defaults to false # Defaults to $facts['os_service_default'].
# #
class neutron::agents::ml2::ovs ( class neutron::agents::ml2::ovs (
$package_ensure = 'present', $package_ensure = 'present',
@ -330,7 +330,7 @@ class neutron::agents::ml2::ovs (
$network_log_rate_limit = $facts['os_service_default'], $network_log_rate_limit = $facts['os_service_default'],
$network_log_burst_limit = $facts['os_service_default'], $network_log_burst_limit = $facts['os_service_default'],
$network_log_local_output_log_base = $facts['os_service_default'], $network_log_local_output_log_base = $facts['os_service_default'],
Boolean $openflow_processed_per_port = false, $openflow_processed_per_port = $facts['os_service_default'],
) { ) {
include neutron::deps include neutron::deps

5
releasenotes/notes/openflow_processed_per_port-6587301ed42b53e9.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
The new ``neutron::agents::ml2::ovs::openflow_processed_per_port``
parameter has been added.

1
spec/classes/neutron_agents_ml2_ovs_spec.rb
View File

@ -91,6 +91,7 @@ describe 'neutron::agents::ml2::ovs' do
should contain_neutron_agent_ovs('network_log/rate_limit').with_value('<SERVICE DEFAULT>') should contain_neutron_agent_ovs('network_log/rate_limit').with_value('<SERVICE DEFAULT>')
should contain_neutron_agent_ovs('network_log/burst_limit').with_value('<SERVICE DEFAULT>') should contain_neutron_agent_ovs('network_log/burst_limit').with_value('<SERVICE DEFAULT>')
should contain_neutron_agent_ovs('network_log/local_output_log_base').with_value('<SERVICE DEFAULT>') should contain_neutron_agent_ovs('network_log/local_output_log_base').with_value('<SERVICE DEFAULT>')
should contain_neutron_agent_ovs('ovs/openflow_processed_per_port').with_value('<SERVICE DEFAULT>')
end end
it 'installs neutron ovs agent package' do it 'installs neutron ovs agent package' do