Fix incorrect VPNaaS packages

As of Queens the VPNaaS package to be used is no longer
neutron-vpn-agent and has been replaced with the package
python-neutron-vpnaas.

The package for openswan does not exist for Debian systems
and needs to be updated to strongswan instead.

Change-Id: I859c80facc9dadf461c2300a6c354c73ae60e5e4
Closes-bug: #1825700

manifests/params.pp

@@ -130,8 +130,8 @@ class neutron::params {
     $dhcp_agent_package         = 'neutron-dhcp-agent'
     $lbaasv2_agent_package      = 'neutron-lbaasv2-agent'
     $metering_agent_package     = 'neutron-metering-agent'
-    $vpnaas_agent_package       = 'neutron-vpn-agent'
+    $vpnaas_agent_package       = 'python-neutron-vpnaas'
-    $openswan_package           = 'openswan'
+    $openswan_package           = 'strongswan'
     $libreswan_package          = false
     $metadata_agent_package     = 'neutron-metadata-agent'
     $l3_agent_package           = 'neutron-l3-agent'

manifests/services/fwaas.pp

@@ -60,7 +60,8 @@ class neutron::services::fwaas (
   if ($::osfamily == 'Debian') {
     # Debian platforms
     if $vpnaas_agent_package {
-      ensure_resource( 'package', $::neutron::params::vpnaas_agent_package, {
+      ensure_resource( 'package', 'neutron-vpn-agent', {
+        'name'   => $::neutron::params::vpnaas_agent_package,
         'ensure' => $neutron::package_ensure,
         'tag'    => ['neutron-package', 'openstack'],
       })

releasenotes/notes/vpnaas_ubuntu_package_fix-7c0e74066ad01e7e.yaml

@@ -0,0 +1,8 @@
+---
+fixes:
+  - |
+    As of Queens the neutron-vpn-agent package for Ubuntu is no longer provided and
+    has been replaced with the package python-neutron-vpnaas.
+  - |
+    On Debian there is no package named openswan and the package that should be
+    installed for VPNaaS is strongswan.

spec/classes/neutron_agents_vpnaas_spec.rb

@@ -128,7 +128,7 @@ describe 'neutron::agents::vpnaas' do
         case facts[:osfamily]
         when 'Debian'
           {
-            :openswan_package     => 'openswan',
+            :openswan_package     => 'strongswan',
             :vpnaas_agent_package => 'neutron-vpn-agent'
           }
         when 'RedHat'

spec/classes/neutron_services_fwaas_spec.rb

@@ -90,6 +90,7 @@ describe 'neutron::services::fwaas' do
       it 'installs neutron vpnaas agent package' do
         should contain_package('neutron-vpn-agent').with(
           :ensure => 'present',
+          :name   => platform_params[:vpnaas_package_name],
           :tag    => ['neutron-package', 'openstack'],
         )
       end
@@ -117,7 +118,8 @@ describe 'neutron::services::fwaas' do
         case facts[:osfamily]
         when 'Debian'
           { 
-            :fwaas_package_name => 'python3-neutron-fwaas'
+            :fwaas_package_name   => 'python3-neutron-fwaas',
+            :vpnaas_package_name  => 'python-neutron-vpnaas'
           }
         when 'RedHat'
           {

spec/classes/neutron_services_vpnaas_spec.rb

@@ -67,7 +67,7 @@ describe 'neutron::services::vpnaas' do
         case facts[:osfamily]
         when 'Debian'
           {
-            :vpnaas_package_name => 'neutron-vpn-agent'
+            :vpnaas_package_name => 'python-neutron-vpnaas'
           }
         when 'RedHat'
           {