openstack/puppet-neutron
Code Issues Proposed changes

Remove deprecated neutron::manage_logging

Browse Source 
The deprecated parameter manage_logging in ::neutron
has no effect and was deprecated in Stein and can be
removed now.

Change-Id: I43e8d442d3ca9bc0fb19d16157b5afd53157a8cc
This commit is contained in:
Tobias Urdin 2019-09-20 13:37:37 +02:00
parent 47f97fcbf9
commit 79908143ce
2 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
manifests/init.pp
View File

@ -321,13 +321,6 @@
# (optional) Allow plugins that support it to create VLAN transparent networks # (optional) Allow plugins that support it to create VLAN transparent networks
# Defaults to $::os_service_default # Defaults to $::os_service_default
# #
## DEPRECATED PARAMS
#
# [*manage_logging*]
# (optional) Whether to manage oslo.logging options
# If set to false, neutron::logging class should be evaluated
# Defaults to undef.
#
class neutron ( class neutron (
$enabled = true, $enabled = true,
$package_ensure = 'present', $package_ensure = 'present',
@ -395,17 +388,11 @@ class neutron (
$notification_transport_url = $::os_service_default, $notification_transport_url = $::os_service_default,
$max_allowed_address_pair = $::os_service_default, $max_allowed_address_pair = $::os_service_default,
$vlan_transparent = $::os_service_default, $vlan_transparent = $::os_service_default,
## DEPRECATED PARAMS
$manage_logging = undef,
) { ) {
include ::neutron::deps include ::neutron::deps
include ::neutron::params include ::neutron::params
if $manage_logging {
warning('neutron::manage_logging is deprecated and has no effect, please use neutron::logging class')
}
if ! is_service_default($use_ssl) and ($use_ssl) { if ! is_service_default($use_ssl) and ($use_ssl) {
if is_service_default($cert_file) { if is_service_default($cert_file) {
fail('The cert_file parameter is required when use_ssl is set to true') fail('The cert_file parameter is required when use_ssl is set to true')

4
releasenotes/notes/remove-init-manage-logging-param-05202f4e5cdc2c18.yaml Normal file
View File

@ -0,0 +1,4 @@
---
upgrade:
- |
The deprecated parameter neutron::manage_logging is removed.