openstack/puppet-neutron
Code Issues Proposed changes

Put neutron provider commands in neutron.rb

Browse Source 
This allows to gain access to all neutron commands using composability,
see[1] for an example.  It removes some redundancy as well.  Finally, it
looks more like the openstacklib/**/openstack.rb provider code.

[1] https://review.openstack.org/#/c/347468/

Change-Id: Iad0354f5babd86822e37053f3f7a1134803fd4f8
This commit is contained in:
Sofer Athlan-Guyot 2016-07-27 21:17:28 +02:00
parent 5c12847420
commit 8a85bb0860
6 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/puppet/provider/neutron.rb
View File

@ -3,6 +3,9 @@ require 'puppet/util/inifile'
class Puppet::Provider::Neutron < Puppet::Provider class Puppet::Provider::Neutron < Puppet::Provider
initvars
commands :neutron => 'neutron'
def self.conf_filename def self.conf_filename
'/etc/neutron/neutron.conf' '/etc/neutron/neutron.conf'
end end

2
lib/puppet/provider/neutron_network/neutron.rb
View File

@ -11,8 +11,6 @@ Puppet::Type.type(:neutron_network).provide(
Assumes that the neutron service is configured on the same host. Assumes that the neutron service is configured on the same host.
EOT EOT
commands :neutron => 'neutron'
mk_resource_methods mk_resource_methods
def self.neutron_type def self.neutron_type

2
lib/puppet/provider/neutron_port/neutron.rb
View File

@ -12,8 +12,6 @@ Puppet::Type.type(:neutron_port).provide(
EOT EOT
#TODO No security group support #TODO No security group support
commands :neutron => "neutron"
mk_resource_methods mk_resource_methods
def self.instances def self.instances

2
lib/puppet/provider/neutron_router/neutron.rb
View File

@ -11,8 +11,6 @@ Puppet::Type.type(:neutron_router).provide(
Assumes that the neutron service is configured on the same host. Assumes that the neutron service is configured on the same host.
EOT EOT
commands :neutron => 'neutron'
mk_resource_methods mk_resource_methods
def self.do_not_manage def self.do_not_manage

2
lib/puppet/provider/neutron_router_interface/neutron.rb
View File

@ -17,8 +17,6 @@ Puppet::Type.type(:neutron_router_interface).provide(
EOT EOT
commands :neutron => 'neutron'
mk_resource_methods mk_resource_methods
def self.instances def self.instances

2
lib/puppet/provider/neutron_subnet/neutron.rb
View File

@ -12,8 +12,6 @@ Puppet::Type.type(:neutron_subnet).provide(
Assumes that the neutron service is configured on the same host. Assumes that the neutron service is configured on the same host.
EOT EOT
commands :neutron => 'neutron'
mk_resource_methods mk_resource_methods
def self.neutron_type def self.neutron_type