openstack/puppet-neutron
Code Issues Proposed changes

Fix puppet-lint before upgrading gem

Browse Source 
Removing puppet-lint warnings
in favor of upgrading to latest gem

2016-09-13 21:07:38.653168 | manifests/init.pp:31:WARNING: line has more than 140 characters
2016-09-13 21:07:38.653387 | manifests/init.pp:494:WARNING: line has more than 140 characters
2016-09-13 21:07:38.653444 | manifests/init.pp:497:WARNING: line has more than 140 characters
2016-09-13 21:07:38.653490 | manifests/quota.pp:114:ERROR: trailing whitespace found
2016-09-13 21:07:38.653539 | manifests/server.pp:398:WARNING: line has more than 140 characters
2016-09-13 21:07:38.653591 | manifests/services/lbaas.pp:90:WARNING: line has more than 140 characters
2016-09-13 21:07:38.653645 | manifests/services/vpnaas.pp:48:WARNING: line has more than 140 characters

Change-Id: Id3683aa33e81a91d306632e7435ffb9d3cd88192
This commit is contained in:
Carlos Camacho 2016-09-14 11:40:21 +02:00
parent e48383a14f
commit d7b600de26
5 changed files with 13 additions and 7 deletions

9
manifests/init.pp

@ -28,7 +28,8 @@
# [*core_plugin*]
# (optional) Neutron plugin provider
# Defaults to openvswitch
# Could be bigswitch, brocade, cisco, embrane, hyperv, linuxbridge, midonet, ml2, mlnx, nec, nicira, plumgrid, ryu, nuage, opencontrail (full path)
# Could be bigswitch, brocade, cisco, embrane, hyperv, linuxbridge, midonet,
# ml2, mlnx, nec, nicira, plumgrid, ryu, nuage, opencontrail (full path)
#
# Example for opencontrail:
#
@ -491,10 +492,12 @@ class neutron (
}
}
if (is_service_default($kombu_ssl_certfile) and ! is_service_default($kombu_ssl_keyfile)) or (is_service_default($kombu_ssl_keyfile) and ! is_service_default($kombu_ssl_certfile)) {
if (is_service_default($kombu_ssl_certfile) and ! is_service_default($kombu_ssl_keyfile))
or (is_service_default($kombu_ssl_keyfile) and ! is_service_default($kombu_ssl_certfile)) {
fail('The kombu_ssl_certfile and kombu_ssl_keyfile parameters must be used together')
}
if ! is_service_default($kombu_missing_consumer_retry_timeout) and ! is_service_default($rpc_response_timeout) and ($kombu_missing_consumer_retry_timeout > $rpc_response_timeout) {
if ! is_service_default($kombu_missing_consumer_retry_timeout) and ! is_service_default($rpc_response_timeout)
and ($kombu_missing_consumer_retry_timeout > $rpc_response_timeout) {
warning('kombu_missing_consumer_retry_timeout should not be longer than rpc_response_timeout')
}

1
manifests/quota.pp

@ -111,7 +111,6 @@ class neutron::quota (
$quota_vip = $::os_service_default,
#DEPRECATED PAMAMETERS
$quota_items = undef,
) {
include ::neutron::deps

4
manifests/server.pp

@ -395,7 +395,9 @@ class neutron::server (
}
if !is_service_default($dhcp_load_type) {
validate_re($dhcp_load_type, ['^networks$', '^subnets$', '^ports$'], 'Must pass either networks, subnets, or ports as values for dhcp_load_type')
validate_re($dhcp_load_type,
['^networks$', '^subnets$', '^ports$'],
'Must pass either networks, subnets, or ports as values for dhcp_load_type')
}
if !is_service_default($service_providers) {

3
manifests/services/lbaas.pp

@ -87,7 +87,8 @@ class neutron::services::lbaas (
}
if !is_service_default($service_providers) {
warning('service_providers in neutron::services::lbaas is deprecated in newton release, please use service provider in neutron::server class')
warning('service_providers in neutron::services::lbaas is deprecated in newton \
release, please use service provider in neutron::server class')
}
if $package_ensure {

3
manifests/services/vpnaas.pp

@ -45,7 +45,8 @@ class neutron::services::vpnaas (
include ::neutron::params
if !is_service_default($service_providers) {
warning('service_providers in neutron::services::vpnaas is deprecated in newton release, please use service provider in neutron::server class')
warning('service_providers in neutron::services::vpnaas is deprecated in newton release, \
please use service provider in neutron::server class')
}
# agent package contains both agent and service resources