openstack/puppet-neutron
Code Issues Proposed changes

Fix the default parameter value in spec test

Browse Source 
The default parameter value is 'SERVICE DEFAULT', not 'SERVICE_DEFAULT'.

Change-Id: I8ee14b0d442157610d48d259332a7ead1fe1bdd6
Closes-Bug: #1690973
This commit is contained in:
ZhongShengping 2017-05-16 11:04:31 +08:00
parent b4dcaa0a6c
commit f2f852bb4b
5 changed files with 21 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spec/classes/neutron_services_bgpvpn_spec.rb
View File

@ -20,7 +20,7 @@ describe 'neutron::services::bgpvpn' do
let :default_params do
{ :package_ensure => 'present',
:service_providers => '<SERVICE_DEFAULT>',
:service_providers => '<SERVICE DEFAULT>',
:sync_db => true,
}
end

24
spec/classes/neutron_services_lbaas_haproxy_spec.rb
View File

@ -23,12 +23,12 @@ require 'spec_helper'
describe 'neutron::services::lbaas::haproxy' do
let :default_params do
{ :interface_driver => '<SERVICE_DEFAULT>',
:periodic_interval => '<SERVICE_DEFAULT>',
:loadbalancer_state_path => '<SERVICE_DEFAULT>',
:user_group => '<SERVICE_DEFAULT>',
:send_gratuitous_arp => '<SERVICE_DEFAULT>',
:jinja_config_template => '<SERVICE_DEFAULT>'}
{ :interface_driver => '<SERVICE DEFAULT>',
:periodic_interval => '<SERVICE DEFAULT>',
:loadbalancer_state_path => '<SERVICE DEFAULT>',
:user_group => '<SERVICE DEFAULT>',
:send_gratuitous_arp => '<SERVICE DEFAULT>',
:jinja_config_template => '<SERVICE DEFAULT>'}
end
context 'with default params' do
@ -37,12 +37,12 @@ describe 'neutron::services::lbaas::haproxy' do
end
it 'configures haproxy service plugin' do
is_expected.to contain_neutron_config('haproxy/interface_driver').with_value('<SERVICE_DEFAULT>')
is_expected.to contain_neutron_config('haproxy/periodic_interval').with_value('<SERVICE_DEFAULT>')
is_expected.to contain_neutron_config('haproxy/loadbalancer_state_path').with_value('<SERVICE_DEFAULT>')
is_expected.to contain_neutron_config('haproxy/user_group').with_value('<SERVICE_DEFAULT>')
is_expected.to contain_neutron_config('haproxy/send_gratuitous_arp').with_value('<SERVICE_DEFAULT>')
is_expected.to contain_neutron_config('haproxy/jinja_config_template').with_value('<SERVICE_DEFAULT>')
is_expected.to contain_neutron_config('haproxy/interface_driver').with_value('<SERVICE DEFAULT>')
is_expected.to contain_neutron_config('haproxy/periodic_interval').with_value('<SERVICE DEFAULT>')
is_expected.to contain_neutron_config('haproxy/loadbalancer_state_path').with_value('<SERVICE DEFAULT>')
is_expected.to contain_neutron_config('haproxy/user_group').with_value('<SERVICE DEFAULT>')
is_expected.to contain_neutron_config('haproxy/send_gratuitous_arp').with_value('<SERVICE DEFAULT>')
is_expected.to contain_neutron_config('haproxy/jinja_config_template').with_value('<SERVICE DEFAULT>')
end
end

12
spec/classes/neutron_services_lbaas_octavia_spec.rb
View File

@ -24,9 +24,9 @@ describe 'neutron::services::lbaas::octavia' do
let :default_params do
{ :base_url => 'http://127.0.0.1:9876',
:request_poll_interval => '<SERVICE_DEFAULT>',
:request_poll_timeout => '<SERVICE_DEFAULT>',
:allocates_vip => '<SERVICE_DEFAULT>'}
:request_poll_interval => '<SERVICE DEFAULT>',
:request_poll_timeout => '<SERVICE DEFAULT>',
:allocates_vip => '<SERVICE DEFAULT>'}
end
context 'with default params' do
@ -36,9 +36,9 @@ describe 'neutron::services::lbaas::octavia' do
it 'configures octavia service plugin' do
is_expected.to contain_neutron_config('octavia/base_url').with_value('http://127.0.0.1:9876')
is_expected.to contain_neutron_config('octavia/request_poll_interval').with_value('<SERVICE_DEFAULT>')
is_expected.to contain_neutron_config('octavia/request_poll_timeout').with_value('<SERVICE_DEFAULT>')
is_expected.to contain_neutron_config('octavia/allocates_vip').with_value('<SERVICE_DEFAULT>')
is_expected.to contain_neutron_config('octavia/request_poll_interval').with_value('<SERVICE DEFAULT>')
is_expected.to contain_neutron_config('octavia/request_poll_timeout').with_value('<SERVICE DEFAULT>')
is_expected.to contain_neutron_config('octavia/allocates_vip').with_value('<SERVICE DEFAULT>')
end
end

2
spec/classes/neutron_services_lbaas_spec.rb
View File

@ -23,7 +23,7 @@ require 'spec_helper'
describe 'neutron::services::lbaas' do
let :default_params do
{ :service_providers => '<SERVICE_DEFAULT>'}
{ :service_providers => '<SERVICE DEFAULT>'}
end
shared_examples_for 'neutron lbaas service plugin' do

2
spec/classes/neutron_services_vpnaas_spec.rb
View File

@ -22,7 +22,7 @@ describe 'neutron::services::vpnaas' do
let :default_params do
{ :package_ensure => 'present',
:service_providers => '<SERVICE_DEFAULT>'}
:service_providers => '<SERVICE DEFAULT>'}
end
shared_examples_for 'neutron vpnaas service plugin' do