openstack/puppet-neutron
Code Issues Proposed changes

Corrects ODL-OVS vhostusermode default and docs

Browse Source 
The vhostuser_mode parameter was incorrectly defined as the
client/server mode of OVS, when actually it is the configuration of the
VIF port/QEMU mode.  Therefore a value of 'client' will actually
configure OVS to be in 'server' mode.  This type of port is deprecated
and the correct value should be 'server' (where QEMU creates the port).

Partial-Bug: 1762473

Change-Id: Idda82cae48b11eae1c79c6bbdd85827e3e43e56b
Signed-off-by: Tim Rozet <trozet@redhat.com>
This commit is contained in:
Tim Rozet 2018-04-09 12:26:44 -04:00
parent dfd67c27a3
commit f85794de85
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
manifests/plugins/ovs/opendaylight.pp
View File

@ -59,11 +59,11 @@
# Defaults to "/var/run/openvswitch"
#
# [*vhostuser_mode*]
# (optional) Specify the mode for OVS when creating vhostuser ports.
# Valid values are 'client' or 'server'. In client mode, the hypervisor
# (optional) Specify the mode for the VIF when creating vhostuser ports.
# Valid values are 'client' or 'server'. In client mode, openvswitch
# will be responsible for creating the vhostuser socket. In server mode,
# OVS will create the vhostuser socket.
# Defaults to "client"
# the hypervisor will create the vhostuser socket.
# Defaults to "server"
#
# [*enable_hw_offload*]
# (optional) Configure OVS to use
@ -101,7 +101,7 @@ class neutron::plugins::ovs::opendaylight (
$allowed_network_types = ['local', 'vlan', 'vxlan', 'gre'],
$enable_dpdk = false,
$vhostuser_socket_dir = '/var/run/openvswitch',
$vhostuser_mode = 'client',
$vhostuser_mode = 'server',
$enable_hw_offload = false,
$enable_tls = false,
$tls_key_file = undef,

6
releasenotes/notes/fix-odl-ovs-vhostuser_mode-6a99fc68b305a583.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- |
Fixes default of vhostuser_mode in ODL-OVS to be server, and clarifies
the configuration parameter. See
https://bugs.launchpad.net/tripleo/+bug/1762473

2
spec/classes/neutron_plugins_ovs_opendaylight_spec.rb
View File

@ -14,7 +14,7 @@ describe 'neutron::plugins::ovs::opendaylight' do
:allowed_network_types => ['local', 'vlan', 'vxlan', 'gre'],
:enable_dpdk => false,
:vhostuser_socket_dir => '/var/run/openvswitch',
:vhostuser_mode => 'client',
:vhostuser_mode => 'server',
:enable_hw_offload => false,
:enable_tls => false,
}