This commit makes the following changes, mostly to specs to get them
passing on Puppet 4.x: removes redefinition of $name because it is now
a reserved word and redundant in Puppet 3.x, cleans up the use of
Puppet's old behavior of implicitly converting String to Integers
since Puppet 4.x is pretty strictly typed, sets facts required for
doing flow control and comparison, fixes implicit use of empty string
that is assumed to be the same as false by updating tests that inject
empty string into params to represent a value not being provide by a
user to false instead.
Closes-bug: #1447620
Change-Id: Ibb651f26f33549dbe564dc88167b8f578a03fd77
This patch aim to update our specs test in order to work with the
rspec-puppet release 2.0.0, in the mean time, we update rspec syntax
order to be prepared for rspec 3.x move.
In details:
* Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
* Use shared_examples "a Puppet::Error" for puppet::error tests *
* Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x) *
* Fix spec tests for rspec-puppet 2.0.0
* Clean Gemfile (remove over-specificication of runtime deps of
puppetlabs_spec_helper)
Change-Id: Ida94605916fe26dd4c5fb328f79c4e787d29dcf5
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
