openstack/puppet-nova
Code Issues Proposed changes

Add support for [libvirt] num_volume_scan_tries

Browse Source 
Nova allows tuning retries to scan volume devices, which can be
useful in system where volume operation is slow.

Change-Id: Ifdb7c4ef3a68a2e8cd1d4622c2e6130b5a71e82e
This commit is contained in:
Takashi Kajinami 2023-11-16 12:50:53 +09:00
parent 9412e22cdd
commit 2e5820d772
3 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
manifests/compute/libvirt.pp
View File

@ -171,6 +171,10 @@
# LibVirt as multipath devices.
# Defaults to $facts['os_service_default']
#
# [*num_volume_scan_tries*]
# (optional) Number of times to scan given storage protocol to find volume.
# Defaults to $facts['os_service_default']
#
# [*nfs_mount_options*]
# (optional) Mount options passed to the NFS client. See section of the
# nfs man page for details.
@ -268,6 +272,7 @@ class nova::compute::libvirt (
$file_backed_memory = $facts['os_service_default'],
$images_type = $facts['os_service_default'],
$volume_use_multipath = $facts['os_service_default'],
$num_volume_scan_tries = $facts['os_service_default'],
$nfs_mount_options = $facts['os_service_default'],
$num_pcie_ports = $facts['os_service_default'],
$mem_stats_period_seconds = $facts['os_service_default'],
@ -376,6 +381,7 @@ class nova::compute::libvirt (
'libvirt/file_backed_memory': value => $file_backed_memory;
'libvirt/images_type': value => $images_type;
'libvirt/volume_use_multipath': value => $volume_use_multipath;
'libvirt/num_volume_scan_tries': value => $num_volume_scan_tries;
'libvirt/nfs_mount_options': value => $nfs_mount_options;
'libvirt/num_pcie_ports': value => $num_pcie_ports;
'libvirt/mem_stats_period_seconds': value => $mem_stats_period_seconds;

5
releasenotes/notes/libvirt-num_volume_scan_tries-505bfb29de5dd468.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
The new ``nova::compute::libvirt::num_volume_scan_tries`` parameter has
been added.

3
spec/classes/nova_compute_libvirt_spec.rb
View File

@ -71,6 +71,7 @@ describe 'nova::compute::libvirt' do
it { is_expected.to contain_nova_config('libvirt/file_backed_memory').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/images_type').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/volume_use_multipath').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/num_volume_scan_tries').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/nfs_mount_options').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/num_pcie_ports').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/mem_stats_period_seconds').with_value('<SERVICE DEFAULT>')}
@ -115,6 +116,7 @@ describe 'nova::compute::libvirt' do
:file_backed_memory => 2048,
:images_type => 'raw',
:volume_use_multipath => false,
:num_volume_scan_tries => 3,
:nfs_mount_options => 'rw,intr,nolock',
:num_pcie_ports => 16,
:mem_stats_period_seconds => 20,
@ -158,6 +160,7 @@ describe 'nova::compute::libvirt' do
it { is_expected.to contain_nova_config('libvirt/file_backed_memory').with_value(2048)}
it { is_expected.to contain_nova_config('libvirt/images_type').with_value('raw')}
it { is_expected.to contain_nova_config('libvirt/volume_use_multipath').with_value(false)}
it { is_expected.to contain_nova_config('libvirt/num_volume_scan_tries').with_value(3)}
it { is_expected.to contain_nova_config('libvirt/nfs_mount_options').with_value('rw,intr,nolock')}
it { is_expected.to contain_nova_config('libvirt/num_pcie_ports').with_value(16)}
it { is_expected.to contain_nova_config('libvirt/mem_stats_period_seconds').with_value(20)}