openstack/puppet-nova
Code Issues Proposed changes

CentOS9: Fix unit tests related to mkisofs_cmd

Browse Source 
This is a follow-up of 39d2069119 and
fixes the expected unit test failures in CentOS9.

Change-Id: I19aca5e3ec12536688c35af047dd840a75e7f12c
This commit is contained in:
Takashi Kajinami
2021-12-22 20:41:37 +09:00
parent 3142dc8cdd
commit 4cd055026b
1 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
spec/classes/nova_compute_spec.rb
View File

@@ -35,7 +35,7 @@ describe 'nova::compute' do
end
it { is_expected.to contain_nova_config('DEFAULT/use_cow_images').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('DEFAULT/mkisofs_cmd').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('DEFAULT/mkisofs_cmd').with_value(platform_params[:mkisofs_cmd]) }
it { is_expected.to contain_nova_config('DEFAULT/force_raw_images').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('DEFAULT/virt_mkfs').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('DEFAULT/reserved_host_memory_mb').with_value('<SERVICE DEFAULT>') }
@@ -457,24 +457,33 @@ describe 'nova::compute' do
case facts[:osfamily]
when 'Debian'
let (:platform_params) do
{ :nova_compute_package => 'nova-compute',
{
:nova_compute_package => 'nova-compute',
:nova_compute_service => 'nova-compute',
:mkisofs_package => 'genisoimage' }
:mkisofs_package => 'genisoimage',
:mkisofs_cmd => '<SERVICE DEFAULT>'
}
end
when 'RedHat'
let (:platform_params) do
{ :nova_compute_package => 'openstack-nova-compute',
:nova_compute_service => 'openstack-nova-compute' }
{
:nova_compute_package => 'openstack-nova-compute',
:nova_compute_service => 'openstack-nova-compute'
}
end
if facts[:operatingsystemmajrelease] > '8'
before do
platform_params.merge!({
:mkisofs_package => 'xorriso' })
:mkisofs_package => 'xorriso',
:mkisofs_cmd => 'mkisofs'
})
end
else
before do
platform_params.merge!({
:mkisofs_package => 'genisoimage' })
:mkisofs_package => 'genisoimage',
:mkisofs_cmd => '<SERVICE DEFAULT>'
})
end
end
end