openstack/puppet-nova
Code Issues Proposed changes

Expose use_json logging option

Browse Source 
It enables JSON-formatted logging from oslo.log.

Change-Id: I6d02408c6925b63de2a3f4254351456c69a171f8
This commit is contained in:
Juan Antonio Osorio Robles 2017-11-27 14:23:34 +02:00
parent 1b5f50539b
commit 8c6ce7af30
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
manifests/logging.pp
View File

@ -12,6 +12,10 @@
# (Optional) Use syslog for logging.
# Defaults to $::os_service_default
#
# [*use_json*]
# (Optional) Use json for logging.
# Defaults to $::os_service_default
#
# [*use_stderr*]
# (optional) Use stderr for logging
# Defaults to $::os_service_default
@ -87,6 +91,7 @@
#
class nova::logging(
$use_syslog = $::os_service_default,
$use_json = $::os_service_default,
$use_stderr = $::os_service_default,
$log_facility = $::os_service_default,
$log_dir = '/var/log/nova',
@ -122,6 +127,7 @@ class nova::logging(
debug => $debug_real,
use_stderr => $use_stderr_real,
use_syslog => $use_syslog_real,
use_json => $use_json,
log_dir => $log_dir_real,
syslog_log_facility => $log_facility_real,
logging_context_format_string => $logging_context_format_string,

4
releasenotes/notes/log-json-97ad59aa72f31a67.yaml Normal file
View File

@ -0,0 +1,4 @@
---
features:
- |
Expose use_json logging parameter, which enables JSON formatted logging.

3
spec/classes/nova_logging_spec.rb
View File

@ -24,6 +24,7 @@ describe 'nova::logging' do
:instance_uuid_format => '[instance: %(uuid)s] ',
:log_date_format => '%Y-%m-%d %H:%M:%S',
:use_syslog => true,
:use_json => true,
:use_stderr => false,
:log_facility => 'LOG_FOO',
:log_dir => '/var/log',
@ -57,6 +58,7 @@ describe 'nova::logging' do
it 'configures nova logging settings with default values' do
is_expected.to contain_oslo__log('nova_config').with(
:use_syslog => '<SERVICE DEFAULT>',
:use_json => '<SERVICE DEFAULT>',
:use_stderr => '<SERVICE DEFAULT>',
:log_dir => '/var/log/nova',
:debug => '<SERVICE DEFAULT>',
@ -68,6 +70,7 @@ describe 'nova::logging' do
it 'configures nova logging settings with non-default values' do
is_expected.to contain_oslo__log('nova_config').with(
:use_syslog => true,
:use_json => true,
:use_stderr => false,
:syslog_log_facility => 'LOG_FOO',
:log_dir => '/var/log',