openstack/puppet-nova
Code Issues Proposed changes

Remove support for monkey_patch options

Browse Source 
It was deprecated during 2024.2 cycle[1]. As noted earlier, the actual
options were already removed from nova[2].

[1] 95699cf7d6
[2] 9f48aee9b0ea68f7c8eba6a1f3d076e4194d804d

Change-Id: If4c299f9dcd523da3d4f3b5f921cfcaabe313023
This commit is contained in:
Takashi Kajinami
2025-04-17 23:49:28 +09:00
parent 7d5714c218
commit a284d01e0a
3 changed files with 4 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
manifests/patch/config.pp
View File

@ -1,32 +0,0 @@
# == Class: nova:patch::config
#
# DEPRECATED !!!
# This class is aim to configure nova.patch parameters
#
# === Parameters:
#
# [*monkey_patch*]
# (optional) Apply monkey patching or not
# Defaults to $facts['os_service_default']
#
# [*monkey_patch_modules*]
# (optional) List of modules/decorators to monkey patch
# Defaults to $facts['os_service_default']
#
class nova::patch::config (
$monkey_patch = $facts['os_service_default'],
$monkey_patch_modules = $facts['os_service_default'],
) {
include nova::deps
warning("The nova::patch::config class has been deprecated \"
and will be removed in the future release.")
$monkey_patch_modules_real = pick(join(any2array($monkey_patch_modules), ','), $facts['os_service_default'])
nova_config {
'DEFAULT/monkey_patch': value => $monkey_patch;
'DEFAULT/monkey_patch_modules': value => $monkey_patch_modules_real;
}
}

4
releasenotes/notes/remove-monkey_patch-33c456287e8f0ef0.yaml Normal file
View File

@ -0,0 +1,4 @@
---
upgrade:
- |
The ``nova::patch::config`` class has been removed.

42
spec/classes/nova_patch_config_spec.rb
View File

@ -1,42 +0,0 @@
require 'spec_helper'
describe 'nova::patch::config' do
let :params do
{}
end
shared_examples 'nova::patch::config' do
it { is_expected.to contain_class('nova::deps') }
context 'with default parameters' do
it { is_expected.to contain_nova_config('DEFAULT/monkey_patch').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('DEFAULT/monkey_patch_modules').with_value('<SERVICE DEFAULT>') }
end
context 'when overriding parameters' do
let :params do
{ :monkey_patch => true,
:monkey_patch_modules => ['nova.compute.api:nova.notifications.notify_decorator']
}
end
it { is_expected.to contain_nova_config('DEFAULT/monkey_patch').with_value('true') }
it { is_expected.to contain_nova_config('DEFAULT/monkey_patch_modules').with_value('nova.compute.api:nova.notifications.notify_decorator') }
end
end
on_supported_os({
:supported_os => OSDefaults.get_supported_os
}).each do |os,facts|
context "on #{os}" do
let (:facts) do
facts.merge!(OSDefaults.get_facts())
end
it_configures 'nova::patch::config'
end
end
end