openstack/puppet-nova
Code Issues Proposed changes

Add support for [DEFAULT] periodic_fuzzy_delay

Browse Source 
Change-Id: I799ac9a9bd308308304b8321f6dd6ceb838f982e
This commit is contained in:
Takashi Kajinami
2023-07-12 22:26:08 +09:00
parent d2b3430296
commit d8fbf028c1
3 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
manifests/init.pp
View File

@@ -194,6 +194,11 @@
# (optional) Interval at which nodes report to data store.
# Defaults to $facts['os_service_default']
#
# [*periodic_fuzzy_delay*]
# (otional) Number of seconds to randomly delay when starting the periodic
# task scheduler to reduce stampeding.
# Defaults to $facts['os_service_default']
#
# [*rootwrap_config*]
# (optional) Path to the rootwrap configuration file to use for running commands as root
# Defaults to '/etc/nova/rootwrap.conf'
@@ -411,6 +416,7 @@ class nova(
$state_path = '/var/lib/nova',
$lock_path = $::nova::params::lock_path,
$report_interval = $facts['os_service_default'],
$periodic_fuzzy_delay = $facts['os_service_default'],
$rootwrap_config = '/etc/nova/rootwrap.conf',
Boolean $use_ssl = false,
Array[String[1]] $enabled_ssl_apis = ['metadata', 'osapi_compute'],
@@ -669,6 +675,7 @@ but should be one of: ssh-rsa, ssh-dsa, ssh-ecdsa.")
'DEFAULT/service_down_time': value => $service_down_time;
'DEFAULT/rootwrap_config': value => $rootwrap_config;
'DEFAULT/report_interval': value => $report_interval;
'DEFAULT/periodic_fuzzy_delay': value => $periodic_fuzzy_delay;
}
oslo::concurrency { 'nova_config': lock_path => $lock_path }

4
releasenotes/notes/periodic_fuzzy_delay-0e21c3c4235aa399.yaml Normal file
View File

@@ -0,0 +1,4 @@
---
features:
- |
The new ``nova::periodic_fuzzy_delay`` parameter has been added.

3
spec/classes/nova_init_spec.rb
View File

@@ -83,6 +83,7 @@ describe 'nova' do
is_expected.to contain_nova_config('DEFAULT/service_down_time').with_value('<SERVICE DEFAULT>')
is_expected.to contain_nova_config('DEFAULT/rootwrap_config').with_value('/etc/nova/rootwrap.conf')
is_expected.to contain_nova_config('DEFAULT/report_interval').with_value('<SERVICE DEFAULT>')
is_expected.to contain_nova_config('DEFAULT/periodic_fuzzy_delay').with_value('<SERVICE DEFAULT>')
is_expected.to contain_nova_config('vif_plug_ovs/ovsdb_connection').with_value('<SERVICE DEFAULT>')
is_expected.to contain_nova_config('DEFAULT/long_rpc_timeout').with_value('<SERVICE DEFAULT>')
is_expected.to contain_nova_config('DEFAULT/cpu_allocation_ratio').with_value('<SERVICE DEFAULT>')
@@ -142,6 +143,7 @@ describe 'nova' do
:notification_topics => 'openstack',
:notification_format => 'unversioned',
:report_interval => '10',
:periodic_fuzzy_delay => '61',
:ovsdb_connection => 'tcp:127.0.0.1:6640',
:upgrade_level_cert => '1.0.0',
:upgrade_level_compute => '1.0.0',
@@ -241,6 +243,7 @@ describe 'nova' do
is_expected.to contain_nova_config('DEFAULT/service_down_time').with_value('60')
is_expected.to contain_nova_config('notifications/notification_format').with_value('unversioned')
is_expected.to contain_nova_config('DEFAULT/report_interval').with_value('10')
is_expected.to contain_nova_config('DEFAULT/periodic_fuzzy_delay').with_value('61')
is_expected.to contain_nova_config('vif_plug_ovs/ovsdb_connection').with_value('tcp:127.0.0.1:6640')
is_expected.to contain_nova_config('DEFAULT/long_rpc_timeout').with_value('1800')
is_expected.to contain_nova_config('DEFAULT/ssl_only').with_value(true)