openstack/puppet-nova
Code Issues Proposed changes

Remove logic to handle undef

Browse Source 
The logic was added a few cycles ago[1] when we replaced the old
default value (undef). The logic has not been really useful because
puppet automatically omits the undef values.

[1] 26dbd52717

Change-Id: I5e18ee1946efebfe4abdcf398abd5babffaba545
This commit is contained in:
Takashi Kajinami
2023-01-05 15:24:41 +09:00
parent cd6df2a8af
commit dd41ad8a1a
1 changed files with 3 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
manifests/migration/libvirt.pp
View File

@@ -263,15 +263,8 @@ class nova::migration::libvirt(
if $transport_real == 'tls' {
$auth_tls_real = $auth
$auth_tcp_real = $::os_service_default
$ca_file_real = pick($ca_file, $::os_service_default)
$crl_file_real = pick($crl_file, $::os_service_default)
if $ca_file == undef {
warning('Usage of undef for the ca_file parameter has been deprecated')
}
if $crl_file == undef {
warning('Usage of undef for the crl_file parameter has been deprecated')
}
$ca_file_real = $ca_file
$crl_file_real = $crl_file
} elsif $transport_real == 'tcp' {
$auth_tls_real = $::os_service_default
$auth_tcp_real = $auth
@@ -284,10 +277,6 @@ class nova::migration::libvirt(
$crl_file_real = $::os_service_default
}
if $listen_address == undef {
warning('Usage of undef for the listen_addrss parameter has been deprecated')
}
$libvirt_listen_config = $modular_libvirt_real ? {
true => 'virtproxyd_config',
default => 'libvirtd_config'
@@ -300,7 +289,7 @@ class nova::migration::libvirt(
'auth_tcp' => { 'value' => $auth_tcp_real, 'quote' => true },
'ca_file' => { 'value' => $ca_file_real, 'quote' => true },
'crl_file' => { 'value' => $crl_file_real, 'quote' => true },
'listen_addr' => { 'value' => pick($listen_address, $::os_service_default), 'quote' => true }
'listen_addr' => { 'value' => $listen_address, 'quote' => true }
})
if $transport_real == 'tls' or $transport_real == 'tcp' {