Remove deprecated rbd_keyring

It was deprecated during 2024.2 cycle by [1] and has had no effect
since then.

[1] d033bb39de

Depends-on: https://review.opendev.org/953166
Change-Id: I58339b2e9974ff439108bbeab80e5990aba1cb56

manifests/compute/rbd.pp

@@ -98,12 +98,6 @@
 #   (optional) Manage the libvirt secret
 #   Defaults to true
 #
-# == Deprecated parameters
-#
-# [*rbd_keyring*]
-#   (optional) The keyring name to use when retrieving the RBD secret
-#   Default to undef
-#
 class nova::compute::rbd (
   $libvirt_rbd_user,
   $libvirt_rbd_secret_uuid                      = undef,
@@ -121,17 +115,11 @@ class nova::compute::rbd (
   $ceph_client_ensure                           = 'present',
   $package_ensure                               = 'present',
   Boolean $manage_libvirt_secret                = true,
-  ## DEPRECATED PARAMETERS
-  $rbd_keyring                                  = undef,
 ) {
 
   include nova::deps
   include nova::params
 
-  if $rbd_keyring != undef {
-    warning('The rbd_keyring parameter is deprecated and has no effect')
-  }
-
   if $manage_ceph_client {
     # Install ceph client libraries
     ensure_packages( 'ceph-common', {

releasenotes/notes/remove-rbd_keyring-8a918f435c29735e.yaml

@@ -0,0 +1,4 @@
+---
+upgrade:
+  - |
+    The ``nova::compute::rbd::rbd_keyring`` parameter has been removed.