openstack
/
puppet-nova
Code Issues Proposed changes

Get rid of the $pyvers variable 

Since everyone has switched to Python3, it's time for the removal of the
$pyvers variable.

Change-Id: Ie25511cc2fded0c959efbfa86d83b640fbee6487
This commit is contained in:
Thomas Goirand 2021-05-21 12:08:42 +02:00
parent adce4e7a3f
commit f92f8d0787
3 changed files with 7 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
manifests/params.pp
View File

@ -4,8 +4,8 @@
# should be considered to be constant
class nova::params {
include openstacklib::defaults
$pyvers = $::openstacklib::defaults::pyvers
$client_package = "python${pyvers}-novaclient"
$client_package = 'python3-novaclient'
$group = 'nova'
case $::osfamily {
@ -13,10 +13,10 @@ class nova::params {
# package names
$api_package_name = 'openstack-nova-api'
$common_package_name = 'openstack-nova-common'
$python_package_name = "python${pyvers}-nova"
$python_package_name = 'python3-nova'
$compute_package_name = 'openstack-nova-compute'
$conductor_package_name = 'openstack-nova-conductor'
$novajoin_package_name = "python${pyvers}-novajoin"
$novajoin_package_name = 'python3-novajoin'
$doc_package_name = 'openstack-nova-doc'
$libvirt_package_name = 'libvirt'
$libvirt_guests_package_name = 'libvirt-client'
@ -66,7 +66,7 @@ class nova::params {
# package names
$api_package_name = 'nova-api'
$common_package_name = 'nova-common'
$python_package_name = "python${pyvers}-nova"
$python_package_name = 'python3-nova'
$compute_package_name = 'nova-compute'
$conductor_package_name = 'nova-conductor'
$novajoin_package_name = undef

10
spec/classes/nova_client_spec.rb
View File

@ -29,15 +29,7 @@ describe 'nova::client' do
when 'Debian'
{ :client_package_name => 'python3-novaclient' }
when 'RedHat'
if facts[:operatingsystem] == 'Fedora'
{ :client_package_name => 'python3-novaclient' }
else
if facts[:operatingsystemmajrelease] > '7'
{ :client_package_name => 'python3-novaclient' }
else
{ :client_package_name => 'python-novaclient' }
end
end
{ :client_package_name => 'python3-novaclient' }
end
end

10
spec/classes/nova_metadata_novajoin_api_spec.rb
View File

@ -206,15 +206,7 @@ describe 'nova::metadata::novajoin::api' do
it_behaves_like 'nova::metadata::novajoin::api'
it_behaves_like 'nova::metadata::novajoin::api on RedHat'
let (:platform_params) do
if facts[:operatingsystem] == 'Fedora'
{ :novajoin_package_name => 'python3-novajoin' }
else
if facts[:operatingsystemmajrelease] > '7'
{ :novajoin_package_name => 'python3-novajoin' }
else
{ :novajoin_package_name => 'python-novajoin' }
end
end
{ :novajoin_package_name => 'python3-novajoin' }
end
end
end