openstack/puppet-octavia
Code Issues Proposed changes

[service_auth] password should be secret

Browse Source 
Change-Id: Ibe8c1ff4519cc36d76914c633ab821835e0a1538
This commit is contained in:
Takashi Kajinami 2021-09-23 22:42:15 +09:00
parent eabd0c9fe5
commit 8f7149e0f7
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/service_auth.pp
View File

@ -52,7 +52,7 @@ class octavia::service_auth (
'service_auth/auth_url' : value => $auth_url;
'service_auth/username' : value => $username;
'service_auth/project_name' : value => $project_name;
'service_auth/password' : value => $password;
'service_auth/password' : value => $password, secret => true;
'service_auth/user_domain_name' : value => $user_domain_name;
'service_auth/project_domain_name' : value => $project_domain_name;
'service_auth/auth_type' : value => $auth_type;

4
spec/classes/octavia_service_auth_spec.rb
View File

@ -8,7 +8,7 @@ describe 'octavia::service_auth' do
is_expected.to contain_octavia_config('service_auth/auth_url').with_value('<SERVICE DEFAULT>')
is_expected.to contain_octavia_config('service_auth/username').with_value('<SERVICE DEFAULT>')
is_expected.to contain_octavia_config('service_auth/project_name').with_value('<SERVICE DEFAULT>')
is_expected.to contain_octavia_config('service_auth/password').with_value('<SERVICE DEFAULT>')
is_expected.to contain_octavia_config('service_auth/password').with_value('<SERVICE DEFAULT>').with_secret(true)
is_expected.to contain_octavia_config('service_auth/user_domain_name').with_value('<SERVICE DEFAULT>')
is_expected.to contain_octavia_config('service_auth/project_domain_name').with_value('<SERVICE DEFAULT>')
is_expected.to contain_octavia_config('service_auth/auth_type').with_value('<SERVICE DEFAULT>')
@ -33,7 +33,7 @@ describe 'octavia::service_auth' do
is_expected.to contain_octavia_config('service_auth/auth_url').with_value('http://199.199.199.199:64371')
is_expected.to contain_octavia_config('service_auth/username').with_value('some_user')
is_expected.to contain_octavia_config('service_auth/project_name').with_value('some_project_name')
is_expected.to contain_octavia_config('service_auth/password').with_value('secure123')
is_expected.to contain_octavia_config('service_auth/password').with_value('secure123').with_secret(true)
is_expected.to contain_octavia_config('service_auth/user_domain_name').with_value('my_domain_name')
is_expected.to contain_octavia_config('service_auth/project_domain_name').with_value('our_domain_name')
is_expected.to contain_octavia_config('service_auth/auth_type').with_value('password')