openstack/puppet-openstacklib
Code Issues Proposed changes

Set policy-rc.d file as executable

Browse Source 
Policy-rc.d requires to be set with +x chmod.

Change-Id: I1bad3301729fa6310d9d1a50c22c621ffe44e24a
This commit is contained in:
Denis Egorenko
2016-06-21 18:56:19 +03:00
parent 2fc25c54ce
commit 85d8296030
2 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/puppet/provider/policy_rcd/policy_rcd.rb
View File

@@ -33,6 +33,7 @@ Puppet::Type.type(:policy_rcd).provide(:policy_rcd) do
policy = File.open(file, 'a+')
policy.puts(content)
policy.close
File.chmod(0744, file)
end
def exists?
@@ -51,7 +52,7 @@ Puppet::Type.type(:policy_rcd).provide(:policy_rcd) do
def create
unless check_policy_rcd
header = "# THIS FILE MANAGED BY PUPPET\n#!/bin/bash\n"
header = "#!/bin/bash\n# THIS FILE MANAGED BY PUPPET\n"
else
header = ""
end

22
spec/unit/provider/policy_rcd/policy_rcd_spec.rb
View File

@@ -20,13 +20,17 @@ describe provider_class do
resource.provider
end
let(:header) do
"#!/bin/bash\n# THIS FILE MANAGED BY PUPPET\n"
end
describe 'managing policy' do
describe '#create' do
it 'creates a policy when policy-rc.d doesnt exist' do
file = mock('file')
provider.stubs(:policy_rcd).returns(file)
File.expects(:exist?).with(file).returns(false)
content = "# THIS FILE MANAGED BY PUPPET\n#!/bin/bash\n[[ \"$1\" == \"service\" ]] && exit 101\n"
content = "#{header}[[ \"$1\" == \"service\" ]] && exit 101\n"
provider.class.expects(:write_to_file).with(file, content)
provider.create
end
@@ -44,11 +48,11 @@ describe provider_class do
describe '#destroy' do
it 'destroy a policy' do
file = mock('file')
file_content = "# THIS FILE MANAGED BY PUPPET\n#!/bin/bash\n[[ \"$1\" == \"service\" ]] && exit 101\n"
file_content = "#{header}[[ \"$1\" == \"service\" ]] && exit 101\n"
provider.stubs(:policy_rcd).returns(file)
File.expects(:exist?).with(file).returns(true)
provider.stubs(:file_lines).returns(file_content.split("\n"))
provider.class.expects(:write_to_file).with(file, ['# THIS FILE MANAGED BY PUPPET', '#!/bin/bash'], true)
provider.class.expects(:write_to_file).with(file, ['#!/bin/bash', '# THIS FILE MANAGED BY PUPPET'], true)
provider.destroy
end
end
@@ -57,15 +61,15 @@ describe provider_class do
it 'update a policy' do
file = mock('file')
provider.stubs(:policy_rcd).returns(file)
file_content = "# THIS FILE MANAGED BY PUPPET\n#!/bin/bash\n[[ \"$1\" == \"service\" ]] && exit 102\n"
file_content = "#{header}[[ \"$1\" == \"service\" ]] && exit 102\n"
provider.stubs(:file_lines).returns(file_content.split("\n"))
provider.class.expects(:write_to_file).with(file, ["# THIS FILE MANAGED BY PUPPET", "#!/bin/bash", "[[ \"$1\" == \"service\" ]] && exit 101\n"], true)
provider.class.expects(:write_to_file).with(file, ['#!/bin/bash', "# THIS FILE MANAGED BY PUPPET", "[[ \"$1\" == \"service\" ]] && exit 101\n"], true)
provider.flush
end
it 'dont update a policy' do
file = mock('file')
file_content = "# THIS FILE MANAGED BY PUPPET\n#!/bin/bash\n[[ \"$1\" == \"service\" ]] && exit 101\n"
file_content = "#{header}[[ \"$1\" == \"service\" ]] && exit 101\n"
provider.stubs(:policy_rcd).returns(file)
provider.stubs(:file_lines).returns(file_content.split("\n"))
provider.flush
@@ -76,7 +80,7 @@ describe provider_class do
it 'should exists on Debian family' do
provider.stubs(:check_os).returns(true)
file = mock('file')
file_content = "# THIS FILE MANAGED BY PUPPET\n#!/bin/bash\n[[ \"$1\" == \"service\" ]] && exit 101\n"
file_content = "#{header}[[ \"$1\" == \"service\" ]] && exit 101\n"
provider.stubs(:policy_rcd).returns(file)
provider.stubs(:check_policy_rcd).returns(true)
provider.stubs(:file_lines).returns(file_content.split("\n"))
@@ -86,7 +90,7 @@ describe provider_class do
it 'should not exists on Debian family when file is present' do
provider.stubs(:check_os).returns(true)
file = mock('file')
file_content = "# THIS FILE MANAGED BY PUPPET\n#!/bin/bash\n[[ \"$1\" == \"new-service\" ]] && exit 101\n"
file_content = "#{header}[[ \"$1\" == \"new-service\" ]] && exit 101\n"
provider.stubs(:policy_rcd).returns(file)
provider.stubs(:check_policy_rcd).returns(true)
provider.stubs(:file_lines).returns(file_content.split("\n"))
@@ -113,6 +117,7 @@ describe provider_class do
File.expects(:open).with(file, 'a+').returns(policy)
policy.expects(:puts).with(content)
policy.expects(:close)
File.expects(:chmod).with(0744, file)
provider.class.write_to_file(file, content)
end
@@ -124,6 +129,7 @@ describe provider_class do
File.expects(:open).with(file, 'a+').returns(policy)
policy.expects(:puts).with(content)
policy.expects(:close)
File.expects(:chmod).with(0744, file)
provider.class.write_to_file(file, content, true)
end
end