Since puppetlabs-stdlib 8.0.0, ensure_packages automatically translates
'ensure => present' to 'ensure => installed' and that translation
breaks existing assertions in unit tests.
Change-Id: I35500af08e39725bab61be036f780c74e38313b9
openstacklib::policy has never been used in any other modules because
it was implemented as a class not reusable for each service.
This change re-implements openstacklib::policy as a defined resource
type so that we can use this implementation from each puppet modules.
The openstacklib::policy resource type provides the purge_config
parameter. When this parameter is set to true, a policy file is cleared
during configuration process. This allows users to remove any existing
rules before applying their own (no) rules.
Change-Id: I9bb486c9191c50c11717dcb9c6af00d17c3aa8f5
The iscsid service is used in sevral components like nova, cinder,
glance and so on to connect to iscsi devices. This change introduces
the new class to manage basic configuration of the iscsid service.
Co-authored-by: Alfredo Moralejo <amoralej@redhat.com>
Change-Id: I3fc6d1192632cc1458d00900508d548f522e9cdb
Fedora support is never tested, and has been unmaintained for a while.
Because we don't expect any actual user using OpenStack on Fedora, this
change drops support for Fedora directly.
Change-Id: I63c96cd92bad210c0a9527c59f8e1347967172a3
This patch adds a 'file_format' field to the policies definition to
allow overriding the default file format which is currently json.
Change-Id: Iec610053a9250cb78c2a17bfc2c197bf55d9df86
Related-Bug: #1885602
We only test and support Puppet 4 and Puppet 5
now and this parameter to the Package resource
defaults to true in these versions making this
unneccesary.
Change-Id: I1459cf5382cd3090c051b25c884399d5cf37d264
This change adds support for installing the
python3-openstackclient package on Debian.
On Ubuntu and RedHat based the package name
is still python-openstackclient.
Change-Id: I8a0c5dfa9274dca167ad3bb33ab151fb693f5d4d
This change updates the tests to use rspec-puppet-facts when doing
different OS testing. Additionally as part of this change, there are
improvements to the openstacklib::policycrd testing which uncovered
issues with the verify_contents catalog test. The verify_contents calls
have been replaced with heredocs to better test when multiple services
are excluded.
Change-Id: I86bae2b16026e15b6e4445f3749419b8802bc94d
This file is to be included by all puppet modules.
First feature is to make sure that allow_virtual is set to true for all
openstack modules. It's set to false for puppet 3.6.1 to
4.0.0 [1]
[1] https://docs.puppet.com/puppet/3.6/reference/release_notes.html#puppet-361
Change-Id: I9d0a10d48124ee71ea80134ceef96436c8ee196e
Closes-Bug: 1599113
Related-Bug: 1597753
Depends-On: I2699eaa3a10589c9a0c680bb1de489994fe01b67
On debian os family systems the methodology is to
start services when installed. This causes a problem
with keystone sometimes at random in CI jobs.
Change-Id: Id0b38743a9bf536f69d155e1d6e664a5585e5e1d
This patch aim to update our specs test in order to work with the rspec-puppet
release 2.0.0, in the mean time, we update rspec syntax order to be prepared
for rspec 3.x move.
In details:
* Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
* Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x)
* Fix spec tests for rspec-puppet 2.0.0
* Clean Gemfile (remove over-specificication of runtime deps of
puppetlabs_spec_helper)
Change-Id: Ice356e35a65204a62e47f49dd4f5816208a6dace
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
Currently puppet modules does not allow one to manage policy.json.
This commit aims to create a common resource for people to manage
their policies.
Change-Id: I1cd7765cdcbddb7e7ad5d720f1efa382641712f2