openstack/puppet-oslo
Code Issues Proposed changes

Change memcache_socket_timeout to a float

Browse Source 
see https://review.opendev.org/#/c/519353/

Change-Id: Ia727f5467a3b499bc2af78868adf8c872be684e1
Closes-Bug: #1835162
This commit is contained in:
ZhongShengping
2019-07-03 14:46:23 +08:00
parent 81289178e6
commit 08476e4e73
3 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/cache.pp
View File

@@ -94,7 +94,7 @@
# [*memcache_socket_timeout*]
# (Optional) Timeout in seconds for every call to a server.
# (dogpile.cache.memcache and oslo_cache.memcache_pool backends only).
# (integer value)
# (floating point value)
# Defaults to $::os_service_default
#
# [*memcache_pool_maxsize*]

4
releasenotes/notes/memcache_socket_timeout-9daa8981f42caf41.yaml Normal file
View File

@@ -0,0 +1,4 @@
---
features:
- |
`memcache_socket_timeout` is changed to float value.

4
spec/defines/oslo_cache_spec.rb
View File

@@ -36,7 +36,7 @@ describe 'oslo::cache' do
:debug_cache_backend => true,
:memcache_servers => ['host1:11211', 'host2:11211','[fd12:3456:789a:1::1]:11211'],
:memcache_dead_retry => '300',
:memcache_socket_timeout => '3',
:memcache_socket_timeout => '3.0',
:memcache_pool_maxsize => '10',
:memcache_pool_unused_timeout => '60',
:memcache_pool_connection_get_timeout => '10',
@@ -53,7 +53,7 @@ describe 'oslo::cache' do
is_expected.to contain_keystone_config('cache/debug_cache_backend').with_value('true')
is_expected.to contain_keystone_config('cache/memcache_servers').with_value('host1:11211,host2:11211,inet6:[fd12:3456:789a:1::1]:11211')
is_expected.to contain_keystone_config('cache/memcache_dead_retry').with_value('300')
is_expected.to contain_keystone_config('cache/memcache_socket_timeout').with_value('3')
is_expected.to contain_keystone_config('cache/memcache_socket_timeout').with_value('3.0')
is_expected.to contain_keystone_config('cache/memcache_pool_maxsize').with_value('10')
is_expected.to contain_keystone_config('cache/memcache_pool_unused_timeout').with_value('60')
is_expected.to contain_keystone_config('cache/memcache_pool_connection_get_timeout').with_value('10')