openstack/puppet-placement
Code Issues Proposed changes

Use undef for package/service name

Browse Source 
... instead of booleans, so that we can implement type enforcement
more easily.

Change-Id: I5d327a665e18cdaeaa9cdaea85a6fc92f320098d
This commit is contained in:
Takashi Kajinami 2023-12-11 22:19:21 +09:00
parent 7f02cb0ea0
commit 2013f99622
2 changed files with 4 additions and 4 deletions
manifests
params.pp
spec/classes
placement_api_spec.rb

4
manifests/params.pp

@ -14,7 +14,7 @@ class placement::params {
$common_package_name = 'openstack-placement-common' $common_package_name = 'openstack-placement-common'
$python_package_name = 'python3-placement' $python_package_name = 'python3-placement'
$osc_package_name = 'python3-osc-placement' $osc_package_name = 'python3-osc-placement'
$service_name = false $service_name = undef
$public_url = 'http://127.0.0.1/placement' $public_url = 'http://127.0.0.1/placement'
$internal_url = 'http://127.0.0.1/placement' $internal_url = 'http://127.0.0.1/placement'
$admin_url = 'http://127.0.0.1/placement' $admin_url = 'http://127.0.0.1/placement'
@ -31,7 +31,7 @@ class placement::params {
$service_name = 'placement-api' $service_name = 'placement-api'
} }
default: { default: {
$service_name = false $service_name = undef
} }
} }
$public_url = 'http://127.0.0.1' $public_url = 'http://127.0.0.1'

4
spec/classes/placement_api_spec.rb

@ -81,11 +81,11 @@ describe 'placement::api' do
{ :service_name => 'placement-api', { :service_name => 'placement-api',
:package_name => 'placement-api'} :package_name => 'placement-api'}
else else
{ :service_name => false, { :service_name => nil,
:package_name => 'placement-api'} :package_name => 'placement-api'}
end end
when 'RedHat' when 'RedHat'
{ :service_name => false, { :service_name => nil,
:package_name => 'openstack-placement-api'} :package_name => 'openstack-placement-api'}
end end
end end