Browse Source

Fix lint errors with the latest lint packages

This change fixes the following lint errors discovered since we removed
pin of lint packages.

manifests/containerreconciler.pp:110:WARNING: absolute class name
reference
manifests/containerreconciler.pp:110:WARNING: absolute class name
reference
manifests/containerreconciler.pp:91:WARNING: class included by absolute
name (::$class)
manifests/objectexpirer.pp:159:WARNING: absolute class name reference
manifests/objectexpirer.pp:159:WARNING: absolute class name reference
manifests/objectexpirer.pp:130:WARNING: class included by absolute name
(::$class)
manifests/proxy.pp:192:WARNING: class included by absolute name
(::$class)
manifests/proxy/cache.pp:63:WARNING: absolute class name reference
manifests/proxy/cache.pp:63:WARNING: absolute class name reference
manifests/storage/account.pp:35:WARNING: class included by absolute
name (::$class)
manifests/storage/all.pp:32:WARNING: Duplicate class parameter
documentation for swift::storage::all::allow_versions
manifests/storage/all.pp:15:WARNING: Duplicate class parameter
documentation for swift::storage::all::allow_versions
manifests/storage/container.pp:41:WARNING: class included by absolute
name (::$class)
manifests/storage/object.pp:35:WARNING: class included by absolute name
(::$class)

Change-Id: Ic223f16d234c4385b95197ab460dc38eb561d16a
changes/47/790647/1
Takashi Kajinami 4 months ago
parent
commit
b79e3c965b
  1. 4
      manifests/containerreconciler.pp
  2. 4
      manifests/objectexpirer.pp
  3. 2
      manifests/proxy.pp
  4. 2
      manifests/proxy/cache.pp
  5. 2
      manifests/storage/account.pp
  6. 3
      manifests/storage/all.pp
  7. 2
      manifests/storage/container.pp
  8. 2
      manifests/storage/object.pp

4
manifests/containerreconciler.pp

@ -88,7 +88,7 @@ class swift::containerreconciler(
$cache_tls_cafile = $::os_service_default,
$cache_tls_certfile = $::os_service_default,
$cache_tls_keyfile = $::os_service_default,
) inherits ::swift::params {
) inherits swift::params {
include swift::deps
Swift_config<| |> ~> Service['swift-container-reconciler']
@ -107,7 +107,7 @@ class swift::containerreconciler(
# require the memcached class if it is on the same machine
if !empty(grep(any2array($memcache_servers), '127.0.0.1')) {
Class['::memcached'] -> Class['::swift::containerreconciler']
Class['memcached'] -> Class['swift::containerreconciler']
}
}

4
manifests/objectexpirer.pp

@ -127,7 +127,7 @@ class swift::objectexpirer(
$cache_tls_keyfile = undef,
$log_level = 'INFO',
$log_facility = 'LOG_LOCAL2',
) inherits ::swift::params {
) inherits swift::params {
include swift::deps
Swift_config<| |> ~> Service['swift-object-expirer']
@ -156,7 +156,7 @@ class swift::objectexpirer(
# require the memcached class if it is on the same machine
if !empty(grep(any2array($memcache_servers), '127.0.0.1')) {
Class['::memcached'] -> Class['::swift::objectexpirer']
Class['memcached'] -> Class['swift::objectexpirer']
}
}

2
manifests/proxy.pp

@ -189,7 +189,7 @@ class swift::proxy(
$package_ensure = 'present',
$service_provider = $::swift::params::service_provider,
$purge_config = false,
) inherits ::swift::params {
) inherits swift::params {
include swift::deps
Swift_config<| |> ~> Service['swift-proxy-server']

2
manifests/proxy/cache.pp

@ -60,7 +60,7 @@ class swift::proxy::cache(
# require the memcached class if its on the same machine
if !empty(grep(any2array($memcache_servers), '127.0.0.1')) {
Class['::memcached'] -> Class['::swift::proxy::cache']
Class['memcached'] -> Class['swift::proxy::cache']
}
swift_proxy_config {

2
manifests/storage/account.pp

@ -32,7 +32,7 @@ class swift::storage::account(
$package_ensure = 'present',
$config_file_name = 'account-server.conf',
$service_provider = $::swift::params::service_provider
) inherits ::swift::params {
) inherits swift::params {
include swift::deps
Swift_config<| |> ~> Service['swift-account-reaper']

3
manifests/storage/all.pp

@ -12,9 +12,6 @@
# [*object_port*] Port where object storage server should be hosted.
# Optional. Defaults to 6000.
#
# [*allow_versions*] Boolean to enable the versioning in swift container
# Optional. Default to false.
#
# [*container_port*] Port where the container storage server should be hosted.
# Optional. Defaults to 6001.
#

2
manifests/storage/container.pp

@ -38,7 +38,7 @@ class swift::storage::container(
$allowed_sync_hosts = ['127.0.0.1'],
$config_file_name = 'container-server.conf',
$service_provider = $::swift::params::service_provider
) inherits ::swift::params {
) inherits swift::params {
include swift::deps

2
manifests/storage/object.pp

@ -32,7 +32,7 @@ class swift::storage::object(
$package_ensure = 'present',
$config_file_name = 'object-server.conf',
$service_provider = $::swift::params::service_provider
) inherits ::swift::params {
) inherits swift::params {
include swift::deps

Loading…
Cancel
Save