openstack/puppet-tempest
Code Issues Proposed changes

Merge "Warn ineffective neutron plugin parameters"

Browse Source
This commit is contained in:
Zuul 2023-11-15 17:12:04 +00:00 committed by Gerrit Code Review
commit b5d8c311d6
2 changed files with 6 additions and 4 deletions
manifests
init.pp
spec/classes
tempest_init_spec.rb

8
manifests/init.pp

@ -498,6 +498,12 @@ class tempest(
warning('The tempest_config_file parameter has been deprecated and has no effect')
}
[ 'neutron_bgpvpn_available', 'neutron_vpnaas_available', 'neutron_dr_available' ].each |$opt| {
if getvar($opt) != undef {
warning("The ${opt} parameter has no effect now. Use the neutron_api_extensions parameter instead.")
}
}
include tempest::params
include openstacklib::openstackclient
@ -645,11 +651,9 @@ class tempest(
'service_available/aodh': value => $aodh_available;
'service_available/barbican': value => $barbican_available;
'service_available/manila': value => $manila_available;
'service_available/bgpvpn': value => $neutron_bgpvpn_available;
'service_available/gnocchi': value => $gnocchi_available;
'service_available/designate': value => $designate_available;
'service_available/horizon': value => $horizon_available;
'service_available/l2gw': value => $neutron_l2gw_available;
'service_available/neutron': value => $neutron_available;
'service_available/mistral': value => $mistral_available;
'service_available/vitrage': value => $vitrage_available;

2
spec/classes/tempest_init_spec.rb

@ -300,10 +300,8 @@ describe 'tempest' do
is_expected.to contain_tempest_config('service_available/heat').with(:value => false)
is_expected.to contain_tempest_config('service_available/ceilometer').with(:value => false)
is_expected.to contain_tempest_config('service_available/aodh').with(:value => false)
is_expected.to contain_tempest_config('service_available/bgpvpn').with(:value => false)
is_expected.to contain_tempest_config('service_available/gnocchi').with(:value => false)
is_expected.to contain_tempest_config('service_available/horizon').with(:value => true)
is_expected.to contain_tempest_config('service_available/l2gw').with(:value => false)
is_expected.to contain_tempest_config('service_available/neutron').with(:value => true)
is_expected.to contain_tempest_config('service_available/mistral').with(:value => false)
is_expected.to contain_tempest_config('service_available/vitrage').with(:value => false)