openstack/puppet-trove
Code Issues Proposed changes

removing deprecated options from DEFAULT

Browse Source 
Default values and options for backup operations, such as
backup_namespace, restore_namespace and backup_runner_options,
are already defined in code.
Specific per database values should be defined in the datastore
sections, their presence in the DEFAULT is deprecated and can
cause confusion and generate errors and conflicts.
We should remove these specific values and leave only the
default common storage strategy and storage options for backups.

Change-Id: Iaf4a316087a1d2bd66c80206fb5b5c344b49ec7e
This commit is contained in:
Riccardo Pittau
2016-11-17 11:06:56 +01:00
parent c5ae4010ef
commit 2d2fa6ab8a
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
templates/trove-guestagent.conf.erb
View File

@@ -60,11 +60,6 @@ ignore_dbs = lost+found, mysql, information_schema
# Default configuration for storage strategy and storage options
# for backups
# Strategy information for backups
backup_namespace = trove.guestagent.strategies.backup.mysql_impl
# Additional commandline options to be passed to the backup runner (by strategy). For example:
# backup_runner_options = InnoBackupEx:--no-lock, MySQLDump:--events --routines --triggers
restore_namespace = trove.guestagent.strategies.restore.mysql_impl
storage_strategy = SwiftStorage
storage_namespace = trove.common.strategies.storage.swift
backup_swift_container = database_backups