Remove usage of $::os_service_default

... because it was deprecated during Yoga cycle by [1].

[1] fb9a08d972

Change-Id: I16ed985cc1eee3c923bcd1e5ecdc2266658bed8c

manifests/dpdk.pp

@@ -145,18 +145,10 @@ class vswitch::dpdk (
     }
   }
 
-  if is_service_default($vlan_limit) {
-    warning('Usage of $::os_service_default for vlan_limit is deprecated. Use undef instead')
-    vs_config { 'other_config:vlan-limit':
-      ensure => absent,
-      wait   => true,
-    }
-  } else {
   vs_config { 'other_config:vlan-limit':
     value => $vlan_limit,
     wait  => true,
   }
-  }
 
   if $enable_tso {
     vs_config { 'other_config:userspace-tso-enable':

manifests/ovs.pp

@@ -67,18 +67,10 @@ class vswitch::ovs(
     }
   }
 
-  if is_service_default($vlan_limit) {
-    warning('Usage of $::os_service_default for vlan_limit is deprecated. Use undef instead')
-    vs_config { 'other_config:vlan-limit':
-      ensure => absent,
-      wait   => true,
-    }
-  } else {
   vs_config { 'other_config:vlan-limit':
     value => $vlan_limit,
     wait  => true,
   }
-  }
 
   create_resources('vs_config', $vs_config)
 

releasenotes/notes/remove-os_service_default-160de5d54609083a.yaml

@@ -0,0 +1,5 @@
+---
+upgrade:
+  - |
+    The following parameters no longer accepts ``$::os_service_default`` as
+    the special value to use default. Use ``undef`` instead.