None of supported operating systems have separate ovsdb-service, so
the logic to enable that separate service is unused and useless.
Also current definition of status and hasstatus are just redundant and
can be removed.
Change-Id: I361e55f144b4852f76c00b8dab26c4cec37b29c1
puppetlabs_spec_helper recommends rspec-mocks instead of mocha[1] and
it uses rspec-mocks by default instead of mocha since v 5.0.0[2]
This is the prep work to adapt to that migration.
[1] https://github.com/puppetlabs/puppetlabs_spec_helper/#mock_with
[2] 493f0cbc1c
Closes-Bug: #2004135
Change-Id: I843c72def83a79783d68c9bcf1036d9beddb0e5d
The ovs daemon should be restarted when some dpdk options are updated.
This change fixes the missing trigger for restart.
Closes-Bug: #2003158
Change-Id: Id7371e06d8faa09820cd16e1f34c5ed5824b7a11
If the value is nil or empty then the option should NOT exist. This
change fixes the logic to determine whether the option already exists
which is causing broken idempotency.
Closes-Bug: #1987419
Change-Id: I56f85ca35f8e9ee4e5e8d07c714b65f655b1e9ae
ovs v2.12.0 introduced the option to enable postcopy support[1]. This
adds the capability to manage the option.
[1] https://github.com/openvswitch/ovs/commit/30e834dcb5
Change-Id: Ie295a8207fdac4afb4eff37fe4eb49b3c942ea77
This change introduces a few parameters to enable and configure PMD
Auto Load Balancing feature in ovs-dpdk.
Change-Id: Idec390b4b01a2f79cbd885fd83c8bf902c9816e7
This change introduces the native property to the vs_bridge resource
type to customize mac table size, which is currently implemented in
puppet-ovn by the exec resources.
Closes-Bug: #1958873
Change-Id: I7c2f78aa5f281aa4b24c1fb12dbb38b8d97f64f4
When vs_port is defined with a physical interface name and a bridge
the ovs_redhat provider manages the bridge by the network service.
However previously the cfg file generated doesn't include the required
option to set external ids and the property was unintentionally wiped
out.
This change ensures the external ids are persisted, to avoid broken
idempotency.
Closes-Bug: #1959313
Change-Id: I9d2f540e165cad8dd5532a113431cde395138c86
... because it was required for very old versions of Ubuntu and Debian
and no longer required in recent versions.
Change-Id: Ib5d3ab7cd79470e446a13475d5886c76048bfe5b
It turned out the external_ids property is not reflected on the ovs
bridge after initial creation. This change fixes it and ensures that
the property is applied to the bridge.
Closes-Bug: #1958905
Change-Id: I7c1c2384b8d70b568caffe8d3cc82002cf2502f6
This change implements unit tests for the exec resource which was added
by [1].
[1] 1fe71cf5e359c8f83f11b2673620be822423bf47
Change-Id: I1dd62d917783f66b11e953ab1c8be6a259553782
This change adds support for other_config:dpdk-socket-limit, which
is available since openvswitch 2.12.0[1].
[1] https://github.com/openvswitch/ovs/commit/8411b6ccec
Change-Id: I6a8c65685442477d368820cbb7fcc3a21cddbedd
dpdk-socket-mem accepts a comma-separated list of memory amounts per
socket. This change allows usage of native Array to define per-socket
amounts.
Change-Id: I8faeb44b708cf371e98b56a375a6dcc07d82df3e
Some parameters like vlan_limit or hw-offload expect integer values
and boolean values. However current vs_config accepts only strings
and we need to convert integer or boolena to string in manifests
explicitly.
This change makes vs_config accept integers and booleans so that
we can use more "native" types to define values.
Change-Id: I6f1dfd33cc85d84a53e346f45359ce382e5fda26
This change ensures hardware offload is disabled. Previously when
hw_offload is false, puppet-vswitch didn't manage the configuration,
thus offload was kept enabled if it was enabled in advance.
Change-Id: I654c0f7f5a5efb845484cb610ff07effd4f33aa9
$::os_service_default is not used in puppet-vswitch. This change
deprecates usage of it to prepare replacing it by undef, which is
commonly used instead.
Change-Id: Ibfe94720e28f5ce46977b2db2afa82a6888c28cb
This change defines manifest_dir and module_path expicitly in unit
tests so that modules installed under fixtures directory is properly
loaded.
Closes-Bug: #1930403
Change-Id: I549c03eebd718994f39831d24387a928bc109c08
These two distros are never tested in gate, and there are almost no
activities to keep these support updated for a while.
Change-Id: I6110cd9a62f33e2d046fc2c835aaec73c4532889
There are no requirement of service restart after updating
the cmd-insert-inv-prov parameter in ovs documentation[1], and
it seems that the parameter can be applied with keeping the service
running.
[1] https://docs.openvswitch.org/en/latest/topics/dpdk/bridge/#emc-insertion-probability
Let's remove notify so that changing the value doesn't trigger
service restart.
Change-Id: I2e9f7d3b27547d33914f07005045b55d8ba82514
This change implement support for the hw-offload option in dpdk. This
parameter is already supported in non-dpdk deployment but is also valid
for dpdk deployment.
Change-Id: Ibd285bf73fa10e6e9cd338625662063dc9a1d753
This change introduces support for the vlan_limit option.
This parameter is currently set to 1 by default, but we should set
it to 2 to enable vlan_transparent, which requires nested vlans.
Related-Bug: #1918418
Change-Id: Id9aaab2a1e3ad2d2d43cd5cddf389d20abaf4461
We're referencing some additional $::os facts that we need to properly
set for openstacklib to work with.
Change-Id: I00e5caf3cf5409ec4a12695750960900e721e9f5
In pike release, we have migrated manifests from ovs2.5 to ovs2.6 and
retained the backward compatibility. Removing the ovs2.5 changes
in this cycle as it is no longer used.
Change-Id: I286b2f4d090dda34ec95f24f77baefcb7687ff85
New type for configuring SSL in OVS. Bootstrap mode allows the switch
to accept an initial CA certificate offered by the controller.
Otherwise specify the location of the CA certificate to use in comparing
the controller's cert. OVS only supports a single instance of SSL
configuration so the provider limits the resource declaration to a
single instance named 'system'.
Partially-Implements: blueprint opendaylight-ssl-support
Change-Id: Ic026ee0bc4f385e0f8cd7076b3044feeb935ae45
Signed-off-by: Tim Rozet <trozet@redhat.com>
Ovs 2.8 has support for hardware offload [1]
This patch provides an option to configure it.
[1] https://patchwork.ozlabs.org/patch/767853/
Change-Id: I3c0d24a31f0a1cac2cb8c5da8125051d4348eed6
In OvS 2.7, setting dpdk-init=true enables DPDK
and reconfigures the vswitch with the dpdk parameters
earlier configured in ovsdb. In order to avoid
restarting openvswitch after enabling DPDK and to
use this feature, all the dpdk parameters shall be
configured in ovsdb before enabling DPDK.
Change-Id: I3a33f8287bbabe2bcaf7f4556dd78d5b9d6914b6
Signed-off-by: Karthik S <ksundara@redhat.com>
Configuration of DPDK parameters pmd-cpu-mask, dpdk-lcore-mask,
dpdk-socket-mem are addressed as per OVS2.6, while maintaining
backward compatibility with OVS 2.5
Implements: blueprint ovs-2-6-dpdk
Change-Id: I3227189691df85f265cf84bd4115d8d4c9f979f3
Signed-off-by: karthik s <ksundara@redhat.com>
