Fix the parsing logic which wrongly detects '=' in hash values.
Closes-Bug: #2080944
Change-Id: I8cd8c8f4640941966ac838580dd45ab56cadb6de
(cherry picked from commit 4e4105cf488f2162f27cd81dcd235a2a144488d8)
Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.
Until the requirements repository has as stable/2024.1 branch, tests will
continue to use the upper-constraints list on master.
Change-Id: I2cf110a5ba38033c03d0010ba1316dec88cf45ed
... to resolve the following warning detected by puppet-lint.
WARNING: unsafe interpolation of variable 'foo' in exec command
Note that the lint rule is currently disabled[1].
[1] 56cf30b7e26d2c1a440a83f67ec4d7041dcf5cdb
Change-Id: I5576174e964a9a181603e1f06145415c8ce27344
In case the port is not associated with any physical interfaces,
the provider determines existence of the resource using the same
command. So the logic may be always activated.
On the other hand, in case the port is associated with a physical
interface, the ovs port should be created by network scripts by ifup
call, so it's not necessary to create the ovs port in advance.
Change-Id: Id0c636338d41ee9da1a76ad0264c31c56446ab77
The commands to query or update ovs db records are similar for
different resources (bridge, port and interface).
This creates the base implementation to avoid maintaining similar
logics for multiple resources.
Change-Id: Ibd75f464af984987c27548a08da26dea622c7e79
... and return a sensible error to users, instead of raising failure
when one of the subsequent command fails because the bridge is not
present.
Change-Id: I8c764e3314b0deba44adffb570c4a768cee4e97a
This is follow-up of 0f8e830a093bfc35c1341fc5f6efc97f97992e4e and
add the unit test cases to detect any regression.
Related-Bug: #2043916
Change-Id: I8a4b2bf1ca839f5b8c98000212c313498257460b
This ensures that a different port, which includes name of the port
being created, is ignored when checking whether the target already
exists.
Closes-Bug: #2043921
Change-Id: I4a8db4e7b0da87a00ef097c8e066a11bfc5fde90
Debian 12 was released in June 2023. Recent versions of OpenStack
(actually, 2023.1 and later) no longer support Debian 11.
Change-Id: I5da2e3dab813de45d392208019a98f12d9ce5fed
The params class is the legacy approach to define OS/version specific
values. This replaces the params class by the module hieradata
following the recent standard.
Change-Id: I046267279720e969b0ddde821fafff00e517e728
Add file to the reno documentation build to show release notes for
stable/2023.2.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.2.
Sem-Ver: feature
Change-Id: Ia04adbc0d65d1922819c7a857e8160b1c343085b
Recent update in rspec-puppet removed some of the config interfaces for
old puppet versions[1]. This drops usage of these interfaces to resolve
the following error in unit tests.
```
An error occurred while loading ./spec/unit/provider/manila_spec.rb.
Failure/Error: c.manifest_dir = File.join(fixture_path, 'manifests')
NoMethodError:
undefined method `manifest_dir='...
```
This also removes explicit setting of mock module. The definition is
no longer required since we bumped puppetlabs_spec_helper to v 5.0.0.
[1] 316d95923c
Change-Id: Ic5f1499d207e7f26598632499dafbafe5c6d37ab
This module no longer depends on openstacklib since support for
os_service_default fact was removed by [1].
[1] b70e038fe526972af73d99fe9f3574bed7a31119
Change-Id: Idbaee5937d3686bdaa24b6ea7c954d876202dd8e
... because we are currently using v9.0.0 in CI. Lower version may be
bumped after 2023.2 release.
Change-Id: I0753e2a6e919ece2af39ce2c0acc1b3e7612b296
The directory contains the source files to generate the release note
document, so is not required.
Change-Id: I50802c6ede44982c81a43e9743b4a33da1156276
We've seen release job failures caused by too large tarball, which
contains irrelevant files like git history.
Let's exclude these files to reduce size of the archive.
The file is copied from the puppetlabs repositories with some files
specific to OpenStack projects added.
Change-Id: I97ab5acab1c9c280fd4d943a59b5e0f60828876a
the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.
This also adds type definitions for all parameters.
Change-Id: I0e68a74bdae6e39ada7707f46e54ec180476c0dc
None of supported operating systems have separate ovsdb-service, so
the logic to enable that separate service is unused and useless.
Also current definition of status and hasstatus are just redundant and
can be removed.
Change-Id: I361e55f144b4852f76c00b8dab26c4cec37b29c1