openstack
/
puppet-watcher
Code Issues Proposed changes

Add strict validation about boolean parameters 

This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.

Change-Id: Ic59d8374bb062063518ff8088f50c11045163322
This commit is contained in:
Takashi Kajinami 2023-07-22 23:59:40 +09:00
parent 2ab021d060
commit 2875dba27c
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
manifests/api.pp
View File

@ -72,18 +72,18 @@
# Defaults to 'keystone'
#
class watcher::api (
$package_ensure = 'present',
$enabled = true,
$manage_service = true,
$port = $facts['os_service_default'],
$max_limit = $facts['os_service_default'],
$bind_host = $facts['os_service_default'],
$workers = $facts['os_workers'],
$enable_ssl_api = $facts['os_service_default'],
$service_name = $::watcher::params::api_service_name,
$create_db_schema = false,
$upgrade_db = false,
$auth_strategy = 'keystone',
$package_ensure = 'present',
Boolean $enabled = true,
Boolean $manage_service = true,
$port = $facts['os_service_default'],
$max_limit = $facts['os_service_default'],
$bind_host = $facts['os_service_default'],
$workers = $facts['os_workers'],
$enable_ssl_api = $facts['os_service_default'],
$service_name = $::watcher::params::api_service_name,
Boolean $create_db_schema = false,
Boolean $upgrade_db = false,
$auth_strategy = 'keystone',
) inherits watcher::params {
include watcher::policy

4
manifests/applier.pp
View File

@ -38,8 +38,8 @@
#
class watcher::applier (
$package_ensure = 'present',
$enabled = true,
$manage_service = true,
Boolean $enabled = true,
Boolean $manage_service = true,
$applier_workers = $facts['os_service_default'],
$applier_conductor_topic = $facts['os_service_default'],
$applier_status_topic = $facts['os_service_default'],