openstack
/
puppet-watcher
Code Issues Proposed changes

Do not validate database_connection format 

Currently we validate database_connection in 2 layers, each puppet
modules and puppet-oslo, however this makes it difficult to maintain
validation pattern because we always need to fix both.
This patch removes the validation from each puppet modules so that
we need to maitain only one place, puppet-oslo to update validation
logic.

Change-Id: I367b929e9c3d1e7f1490e3c08a44ccc08620b822
This commit is contained in:
Takashi Kajinami 2020-08-31 17:58:27 +09:00
parent 96af8508e4
commit 2a3555a011
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manifests/db.pp
View File

@ -57,9 +57,6 @@ class watcher::db (
include watcher::deps
validate_legacy(Oslo::Dbconn, 'validate_re', $database_connection,
['^(sqlite|mysql(\+pymysql)?|postgresql):\/\/(\S+:\S+@\S+\/\S+)?'])
oslo::db { 'watcher_config':
connection => $database_connection,
connection_recycle_time => $database_connection_recycle_time,