Do not validate the deprecated parameter

The watcher::api::watcher_client_password parameter was deprecated
during Yoga cycle in favor of the new watcher::watcher_clients_auth
class[1]. Thus the parameter should not be validated.

[1] 16bcc44238

Closes-Bug: #1973316
Change-Id: Ied515e3ba52d9fb9bd96ea24149fa7f6c44db9c5

manifests/api.pp

@@ -220,8 +220,6 @@ class watcher::api (
     include watcher::keystone::authtoken
   }
 
-  validate_legacy(String, 'validate_string', $watcher_client_password)
-
   package { 'watcher-api':
     ensure => $package_ensure,
     name   => $::watcher::params::api_package_name,

releasenotes/notes/bug-1973316-01c21c61c865b3b5.yaml

@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    Validation of the deprecated ``watcher::api::watcher_client_password``
+    parameter has been removed and the parameter is no longer required.