openstack/python-ceilometerclient
Code Issues Proposed changes

delete bash_completion in subcommand

Browse Source 
There are two "completion" in the subcommand table: bash-completion
and bash_completion. but "bash_completion" is not in help information
and it is repeated with "bash-completion", so delete it.

Change-Id: I5f3bc918a1ce5b6283cc865db4383f128b138d5e
Closes-Bug: #1670123
This commit is contained in:
ForestLee 2017-05-01 11:01:34 +08:00
parent 6fcc675245
commit 3c62ce27f6
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ceilometerclient/shell.py
View File

@ -117,19 +117,9 @@ class CeilometerShell(object):
version, 'shell')
self._find_actions(subparsers, submodule)
self._find_actions(subparsers, self)
self._add_bash_completion_subparser(subparsers)
return parser
def _add_bash_completion_subparser(self, subparsers):
subparser = subparsers.add_parser(
'bash_completion',
add_help=False,
formatter_class=HelpFormatter
)
self.subcommands['bash_completion'] = subparser
subparser.set_defaults(func=self.do_bash_completion)
def _find_actions(self, subparsers, actions_module):
for attr in (a for a in dir(actions_module) if a.startswith('do_')):
# I prefer to be hypen-separated instead of underscores.
@ -243,7 +233,6 @@ class CeilometerShell(object):
options.add(option)
commands.remove('bash-completion')
commands.remove('bash_completion')
print(' '.join(commands | options))
@utils.arg('command', metavar='<subcommand>', nargs='?',