openstack/python-cinderclient
Code Issues Proposed changes

Use dictionary literal for dictionary creation

Browse Source 
Dictionary creation could be rewritten as a dictionary literal.
for example:

body = {}
body['provider'] = args.provider

could be rewritten as

body = {'provider': args.provider}

TrivialFix

Change-Id: Ieae7b33332eca31754cbfe91288ef3001c573eb3
This commit is contained in:
Ankit Agrawal 2015-09-24 00:00:25 -07:00
parent 9ac2975363
commit 029b51d378
3 changed files with 19 additions and 17 deletions
cinderclient
tests/unit
test_client.py
v1
shell.py
v2
shell.py

11
cinderclient/tests/unit/test_client.py

@ -49,11 +49,12 @@ class ClientTest(utils.TestCase):
) )
) )
kwargs = {} kwargs = {
kwargs['headers'] = {"X-Foo": "bar"} 'headers': {"X-Foo": "bar"},
kwargs['data'] = ('{"auth": {"tenantName": "fakeService",' 'data': ('{"auth": {"tenantName": "fakeService",'
' "passwordCredentials": {"username": "fakeUser",' ' "passwordCredentials": {"username": "fakeUser",'
' "password": "fakePassword"}}}') ' "password": "fakePassword"}}}')
}
cs = cinderclient.client.HTTPClient("user", None, None, cs = cinderclient.client.HTTPClient("user", None, None,
"http://127.0.0.1:5000") "http://127.0.0.1:5000")

11
cinderclient/v1/shell.py

@ -1225,11 +1225,12 @@ def do_encryption_type_create(cs, args):
"""Creates encryption type for a volume type. Admin only.""" """Creates encryption type for a volume type. Admin only."""
volume_type = _find_volume_type(cs, args.volume_type) volume_type = _find_volume_type(cs, args.volume_type)
body = {} body = {
body['provider'] = args.provider 'provider': args.provider,
body['cipher'] = args.cipher 'cipher': args.cipher,
body['key_size'] = args.key_size 'key_size': args.key_size,
body['control_location'] = args.control_location 'control_location': args.control_location
}
result = cs.volume_encryption_types.create(volume_type, body) result = cs.volume_encryption_types.create(volume_type, body)
_print_volume_encryption_type_list([result]) _print_volume_encryption_type_list([result])

14
cinderclient/v2/shell.py

@ -1660,11 +1660,12 @@ def do_encryption_type_create(cs, args):
"""Creates encryption type for a volume type. Admin only.""" """Creates encryption type for a volume type. Admin only."""
volume_type = _find_volume_type(cs, args.volume_type) volume_type = _find_volume_type(cs, args.volume_type)
body = {} body = {
body['provider'] = args.provider 'provider': args.provider,
body['cipher'] = args.cipher 'cipher': args.cipher,
body['key_size'] = args.key_size 'key_size': args.key_size,
body['control_location'] = args.control_location 'control_location': args.control_location
}
result = cs.volume_encryption_types.create(volume_type, body) result = cs.volume_encryption_types.create(volume_type, body)
_print_volume_encryption_type_list([result]) _print_volume_encryption_type_list([result])
@ -2011,8 +2012,7 @@ def do_manage(cs, args):
volume_metadata = _extract_metadata(args) volume_metadata = _extract_metadata(args)
# Build a dictionary of key/value pairs to pass to the API. # Build a dictionary of key/value pairs to pass to the API.
ref_dict = {} ref_dict = {args.id_type: args.identifier}
ref_dict[args.id_type] = args.identifier
# The recommended way to specify an existing volume is by ID or name, and # The recommended way to specify an existing volume is by ID or name, and
# have the Cinder driver look for 'source-name' or 'source-id' elements in # have the Cinder driver look for 'source-name' or 'source-id' elements in