openstack/python-cinderclient
Code Issues Proposed changes

Add tests for python-cinderclient and style fix

Browse Source 
Add test for cinder extra-specs-list command output.
Add test for cinder list-extension command output.
Fix pep8 issues "E128 continuation line under-indented for visual
indent" in other functions.

Change-Id: I28266af7a6ff23b83899c50cc230f926a44592dc
Partial-Bug: #1463404
This commit is contained in:
Kyrylo Romanenko
2015-06-08 17:10:23 +03:00
parent 91bf760989
commit 1fea0d8b87
1 changed files with 20 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
cinderclient/tests/functional/test_readonly_cli.py
View File

@@ -55,6 +55,11 @@ class CinderClientReadOnlyTests(base.ClientTestBase):
self.assertTrue(2 >= len(headers)) self.assertTrue(2 >= len(headers))
self.assertEqual('Value', headers[1]) self.assertEqual('Value', headers[1])
def test_extra_specs_list(self):
extra_specs_list = self.cinder('extra-specs-list')
self.assertTableHeaders(extra_specs_list, ['ID', 'Name',
'extra_specs'])
def test_list(self): def test_list(self):
list = self.cinder('list') list = self.cinder('list')
self.assertTableHeaders(list, ['ID', 'Status', 'Name', 'Size', self.assertTableHeaders(list, ['ID', 'Status', 'Name', 'Size',
@@ -73,7 +78,8 @@ class CinderClientReadOnlyTests(base.ClientTestBase):
def test_service_list(self): def test_service_list(self):
service_list = self.cinder('service-list') service_list = self.cinder('service-list')
self.assertTableHeaders(service_list, ['Binary', 'Host', 'Zone', self.assertTableHeaders(service_list, ['Binary', 'Host', 'Zone',
'Status', 'State', 'Updated_at']) 'Status', 'State',
'Updated_at'])
def test_snapshot_list(self): def test_snapshot_list(self):
snapshot_list = self.cinder('snapshot-list') snapshot_list = self.cinder('snapshot-list')
@@ -87,3 +93,8 @@ class CinderClientReadOnlyTests(base.ClientTestBase):
def test_type_list(self): def test_type_list(self):
type_list = self.cinder('type-list') type_list = self.cinder('type-list')
self.assertTableHeaders(type_list, ['ID', 'Name']) self.assertTableHeaders(type_list, ['ID', 'Name'])
def test_list_extensions(self):
list_extensions = self.cinder('list-extensions')
self.assertTableHeaders(list_extensions, ['Name', 'Summary', 'Alias',
'Updated'])