openstack/python-cinderclient
Code Issues Proposed changes

Change "Connection refused" to "Connection error"

Browse Source 
The python-requests documentation indicates that the
ConnectionError exception can be raised for reasons other than
"connection refused".  Let's just say "error" rather than
implying the wrong type of failure.

Change-Id: I2205e27c7c68164db430cdfdc71b57b3002b24be
This commit is contained in:
Eric Harney
2014-07-24 17:38:17 -04:00
parent fd8aa39458
commit 20060b102a
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cinderclient/client.py
View File

@@ -315,8 +315,7 @@ class HTTPClient(CinderClientMixin):
else: else:
raise raise
except requests.exceptions.ConnectionError as e: except requests.exceptions.ConnectionError as e:
# Catch a connection refused from requests.request self._logger.debug("Connection error: %s" % e)
self._logger.debug("Connection refused: %s" % e)
if attempts > self.retries: if attempts > self.retries:
msg = 'Unable to establish connection: %s' % e msg = 'Unable to establish connection: %s' % e
raise exceptions.ConnectionError(msg) raise exceptions.ConnectionError(msg)