openstack/python-cinderclient
Code Issues Proposed changes

Fix 'search_opts' unexpected keyword argument error

Browse Source 
When executing 'encryption-type-create' command using resource
name, it will use the findall() in base.py, then error will
occur because list() in findall() used 'search_opts' argument
which list() in VolumeEncryptionTypeManager did not have. Some
other command like 'transfer-delete' met same issue.

This patch will add 'search_opts' argument in list() function
in child class to avoid the bug.

Closes-Bug: #1248519
Related-Bug: #1252665

Change-Id: If1cd8b812af21335e5d4351766539a927a8fbdf4
This commit is contained in:
Xiao Chen
2014-01-20 15:29:55 +08:00
parent a1a36499f4
commit 2f0863b7d4
5 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cinderclient/v1/volume_encryption_types.py
View File

@@ -36,7 +36,7 @@ class VolumeEncryptionTypeManager(base.ManagerWithFind):
""" """
resource_class = VolumeEncryptionType resource_class = VolumeEncryptionType
def list(self): def list(self, search_opts=None):
""" """
List all volume encryption types. List all volume encryption types.

2
cinderclient/v1/volume_transfers.py
View File

@@ -64,7 +64,7 @@ class VolumeTransferManager(base.ManagerWithFind):
""" """
return self._get("/os-volume-transfer/%s" % transfer_id, "transfer") return self._get("/os-volume-transfer/%s" % transfer_id, "transfer")
def list(self, detailed=True): def list(self, detailed=True, search_opts=None):
"""Get a list of all volume transfer. """Get a list of all volume transfer.
:rtype: list of :class:`VolumeTransfer` :rtype: list of :class:`VolumeTransfer`

2
cinderclient/v2/volume_encryption_types.py
View File

@@ -36,7 +36,7 @@ class VolumeEncryptionTypeManager(base.ManagerWithFind):
""" """
resource_class = VolumeEncryptionType resource_class = VolumeEncryptionType
def list(self): def list(self, search_opts=None):
""" """
List all volume encryption types. List all volume encryption types.

2
cinderclient/v2/volume_transfers.py
View File

@@ -64,7 +64,7 @@ class VolumeTransferManager(base.ManagerWithFind):
""" """
return self._get("/os-volume-transfer/%s" % transfer_id, "transfer") return self._get("/os-volume-transfer/%s" % transfer_id, "transfer")
def list(self, detailed=True): def list(self, detailed=True, search_opts=None):
"""Get a list of all volume transfer. """Get a list of all volume transfer.
:rtype: list of :class:`VolumeTransfer` :rtype: list of :class:`VolumeTransfer`

1
doc/source/index.rst
View File

@@ -43,6 +43,7 @@ MASTER
.. _1251385: http://bugs.launchpad.net/python-cinderclient/+bug/1251385 .. _1251385: http://bugs.launchpad.net/python-cinderclient/+bug/1251385
.. _1264415: http://bugs.launchpad.net/python-cinderclient/+bug/1264415 .. _1264415: http://bugs.launchpad.net/python-cinderclient/+bug/1264415
.. _1258489: http://bugs.launchpad.net/python-cinderclient/+bug/1258489 .. _1258489: http://bugs.launchpad.net/python-cinderclient/+bug/1258489
.. _1248519: http://bugs.launchpad.net/python-cinderclient/+bug/1248519
1.0.7 1.0.7
----- -----